From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: wsa@the-dreams.de, andy.shevchenko@gmail.com, linux-i2c@vger.kernel.org
Cc: ysato@users.sourceforge.jp, linux-sh@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus
Date: Fri, 30 Jun 2017 00:54:05 +0000 [thread overview]
Message-ID: <20170630005408.23968-4-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170630005408.23968-1-chris.packham@alliedtelesis.co.nz>
Rather than returning -ENODEV if i2c_pca_add_numbered_bus() fails,
propagate the error to aid debugging.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/i2c/busses/i2c-pca-platform.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index daccef6865e8..853a2abedb05 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -232,9 +232,9 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
return ret;
}
- if (i2c_pca_add_numbered_bus(&i2c->adap) < 0) {
- return -ENODEV;
- }
+ ret = i2c_pca_add_numbered_bus(&i2c->adap);
+ if (ret)
+ return ret;
platform_set_drvdata(pdev, i2c);
--
2.13.0
next prev parent reply other threads:[~2017-06-30 0:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 0:54 [PATCH 0/6] i2c: pca-platform: additional improvements Chris Packham
2017-06-30 0:54 ` [PATCH 1/6] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham
2017-07-02 16:47 ` kbuild test robot
2017-07-02 17:15 ` Geert Uytterhoeven
2017-06-30 0:54 ` [PATCH 2/6] i2c: pca-platform: correctly set algo_data.reset_chip Chris Packham
2017-07-04 14:03 ` Wolfram Sang
2017-06-30 0:54 ` Chris Packham [this message]
2017-06-30 8:40 ` [PATCH 3/6] i2c: pca-platform: propagate error from i2c_pca_add_numbered_bus Andy Shevchenko
2017-06-30 9:01 ` Wolfram Sang
2017-07-02 21:30 ` Chris Packham
2017-07-04 14:04 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 4/6] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham
2017-06-30 0:54 ` [PATCH 5/6] i2c: pca-platform: use device_property_read_u32 Chris Packham
2017-06-30 8:44 ` Andy Shevchenko
2017-06-30 9:03 ` Wolfram Sang
2017-06-30 10:56 ` Andy Shevchenko
2017-07-02 21:51 ` Chris Packham
2017-07-04 14:07 ` Wolfram Sang
2017-06-30 0:54 ` [PATCH 6/6] i2c: pca-platform: drop gpio from platform data Chris Packham
2017-06-30 8:48 ` [PATCH 0/6] i2c: pca-platform: additional improvements Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170630005408.23968-4-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=andy.shevchenko@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wsa@the-dreams.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).