From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: wsa@the-dreams.de, ysato@users.sourceforge.jp,
linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Chris Packham <chris.packham@alliedtelesis.co.nz>
Subject: [PATCH v2 3/4] i2c: pca-platform: use device_property_read_u32
Date: Wed, 05 Jul 2017 10:13:57 +0000 [thread overview]
Message-ID: <20170705101358.17458-4-chris.packham@alliedtelesis.co.nz> (raw)
In-Reply-To: <20170705101358.17458-1-chris.packham@alliedtelesis.co.nz>
Use device_property_read_u32 instead of of_property_read_u32_index to
lookup the "clock-frequency" property.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
Changes in v2:
- move call to device_property_read_u32 to above platform_data usage.
This allows the device property/device tree to go first and
platform_data (if present) can override things. Eventually when all
the platforms using this driver are converted to either use device
properties or a device tree then the platform_data can simply be
deleted.
drivers/i2c/busses/i2c-pca-platform.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index b90193d09d4b..bc2707ffd409 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -177,16 +177,15 @@ static int i2c_pca_pf_probe(struct platform_device *pdev)
if (IS_ERR(i2c->gpio))
return PTR_ERR(i2c->gpio);
+ i2c->adap.timeout = HZ;
+ ret = device_property_read_u32(&pdev->dev, "clock-frequency",
+ &i2c->algo_data.i2c_clock);
+ if (ret)
+ i2c->algo_data.i2c_clock = 59000;
+
if (platform_data) {
i2c->adap.timeout = platform_data->timeout;
i2c->algo_data.i2c_clock = platform_data->i2c_clock_speed;
- } else if (np) {
- i2c->adap.timeout = HZ;
- of_property_read_u32_index(np, "clock-frequency", 0,
- &i2c->algo_data.i2c_clock);
- } else {
- i2c->adap.timeout = HZ;
- i2c->algo_data.i2c_clock = 59000;
}
i2c->algo_data.data = i2c;
--
2.13.0
next prev parent reply other threads:[~2017-07-05 10:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 10:13 [PATCH v2 0/4] i2c: pca-platform: additional improvements Chris Packham
2017-07-05 10:13 ` [PATCH v2 1/4] sh: sh7785lcr: add GPIO lookup table for i2c controller reset Chris Packham
2017-07-05 10:13 ` [PATCH v2 2/4] i2c: pca-platform: unconditionally use devm_gpiod_get_optional Chris Packham
2017-07-05 10:13 ` Chris Packham [this message]
2017-07-05 10:13 ` [PATCH v2 4/4] i2c: pca-platform: drop gpio from platform data Chris Packham
2017-07-05 11:48 ` [PATCH v2 0/4] i2c: pca-platform: additional improvements Andy Shevchenko
2017-07-05 20:44 ` Chris Packham
2017-10-29 17:29 ` Wolfram Sang
2017-12-07 10:42 ` Wolfram Sang
2018-03-23 3:39 ` Chris Packham
2018-03-23 7:50 ` Wolfram Sang
2018-03-24 12:31 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170705101358.17458-4-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=wsa@the-dreams.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).