From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Thu, 04 Jan 2018 19:18:35 +0000 Subject: Re: [PATCH] sh_eth: fix TSU resource handling Message-Id: <20180104.141835.1836351687367008943.davem@davemloft.net> List-Id: References: <20180103170955.343662722@cogentembedded.com> In-Reply-To: <20180103170955.343662722@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sergei.shtylyov@cogentembedded.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org, nobuhiro.iwamatsu.yj@renesas.com From: Sergei Shtylyov Date: Wed, 03 Jan 2018 20:09:49 +0300 > When switching the driver to the managed device API, I managed to break > the case of a dual Ether devices sharing a single TSU: the 2nd Ether port > wouldn't probe. Iwamatsu-san has tried to fix this but his patch was buggy > and he then dropped the ball... > > The solution is to limit calling devm_request_mem_region() to the first > of the two ports sharing the same TSU, so devm_ioremap_resource() can't > be used anymore for the TSU resource... > > Fixes: d5e07e69218f ("sh_eth: use managed device API") > Reported-by: Nobuhiro Iwamatsu > Signed-off-by: Sergei Shtylyov Applied and queued up for -stable, thanks.