From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Date: Fri, 05 Jan 2018 18:59:33 +0000 Subject: Re: [PATCH] sh_eth: fix SH7757 GEther initialization Message-Id: <20180105.135933.100390185879161281.davem@davemloft.net> List-Id: References: <20180104180655.936982989@cogentembedded.com> In-Reply-To: <20180104180655.936982989@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: sergei.shtylyov@cogentembedded.com Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org From: Sergei Shtylyov Date: Thu, 04 Jan 2018 21:06:49 +0300 > Renesas SH7757 has 2 Fast and 2 Gigabit Ether controllers, while the > 'sh_eth' driver can only reset and initialize TSU of the first controller > pair. Shimoda-san tried to solve that adding the 'needs_init' member to the > 'struct sh_eth_plat_data', however the platform code still never sets this > flag. I think that we can infer this information from the 'devno' variable > (set to 'platform_device::id') and reset/init the Ether controller pair > only for an even 'devno'; therefore 'sh_eth_plat_data::needs_init' can be > removed... > > Fixes: 150647fb2c31 ("net: sh_eth: change the condition of initialization") > Signed-off-by: Sergei Shtylyov Applied and queued up for -stable.