From: Andrew Morton <akpm@linux-foundation.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: ysato@users.sourceforge.jp, dalias@libc.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sh: prefer _THIS_IP_ to current_text_addr
Date: Wed, 01 Aug 2018 21:55:30 +0000 [thread overview]
Message-ID: <20180801145530.185dab6b47a61842923fc02d@linux-foundation.org> (raw)
In-Reply-To: <20180801185331.39535-1-ndesaulniers@google.com>
On Wed, 1 Aug 2018 11:53:31 -0700 Nick Desaulniers <ndesaulniers@google.com> wrote:
> As part of the effort to reduce the code duplication between _THIS_IP_
> and current_text_addr(), let's consolidate callers of
> current_text_addr() to use _THIS_IP_.
Why not switch everything to current_text_addr()? _THIS_IP_ is ugly ;)
Several architectures (s390, sparc, sh, ...) do funky things in their
current_text_addr(). Does the generic kernel.h implementation of
current_text_addr() work OK on those architectures?
next prev parent reply other threads:[~2018-08-01 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 18:29 [PATCH] sh: dwarf: prefer _THIS_IP_ to current_text_addr Nick Desaulniers
2018-08-01 18:50 ` Nick Desaulniers
2018-08-01 18:53 ` [PATCH v2] sh: " Nick Desaulniers
2018-08-01 21:55 ` Andrew Morton [this message]
2018-08-01 22:06 ` Nick Desaulniers
2018-08-01 22:22 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801145530.185dab6b47a61842923fc02d@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ndesaulniers@google.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).