From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Tue, 28 May 2019 10:40:18 +0000 Subject: Re: [PATCH] [RFC] Remove bdflush syscall stub Message-Id: <20190528104017.GA11969@rei> List-Id: References: <20190528101012.11402-1-chrubis@suse.cz> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Schwab Cc: lkml , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Michal Simek , linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org, linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Hi! > > I've tested the patch on i386. Before the patch calling bdflush() with > > attempt to tune a variable returned 0 and after the patch the syscall > > fails with EINVAL. > > Should be ENOSYS, doesn't it? My bad, the LTP syscall wrapper handles ENOSYS and produces skipped results based on that. EINVAL is what you get for not yet implemented syscalls, i.e. new syscall on old kernel. -- Cyril Hrubis chrubis@suse.cz