From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Thu, 30 May 2019 13:39:54 +0000 Subject: Re: [RFC] mm: Generalize notify_page_fault() Message-Id: <20190530133954.GA2024@bombadil.infradead.org> List-Id: References: <1559195713-6956-1-git-send-email-anshuman.khandual@arm.com> <20190530110639.GC23461@bombadil.infradead.org> <4f9a610d-e856-60f6-4467-09e9c3836771@arm.com> In-Reply-To: <4f9a610d-e856-60f6-4467-09e9c3836771@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Anshuman Khandual Cc: Mark Rutland , Michal Hocko , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Catalin Marinas , Will Deacon , linux-mm@kvack.org, Paul Mackerras , sparclinux@vger.kernel.org, linux-s390@vger.kernel.org, Yoshinori Sato , Michael Ellerman , Russell King , Fenghua Yu , Stephen Rothwell , Andrey Konovalov , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Tony Luck , Heiko Carstens , linux-kernel@vger.kernel.org, Martin Schwidefsky , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" On Thu, May 30, 2019 at 05:31:15PM +0530, Anshuman Khandual wrote: > On 05/30/2019 04:36 PM, Matthew Wilcox wrote: > > The two handle preemption differently. Why is x86 wrong and this one > > correct? > > Here it expects context to be already non-preemptible where as the proposed > generic function makes it non-preemptible with a preempt_[disable|enable]() > pair for the required code section, irrespective of it's present state. Is > not this better ? git log -p arch/x86/mm/fault.c search for 'kprobes'. tell me what you think.