From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 06 Jun 2019 06:20:18 +0000 Subject: Re: [PATCH 12/16] mm: consolidate the get_user_pages* implementations Message-Id: <20190606062018.GA26745@lst.de> List-Id: References: <20190601074959.14036-1-hch@lst.de> <20190601074959.14036-13-hch@lst.de> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: John Hubbard Cc: Christoph Hellwig , Linus Torvalds , Paul Burton , James Hogan , Yoshinori Sato , Rich Felker , "David S. Miller" , Nicholas Piggin , Khalid Aziz , Andrey Konovalov , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org On Wed, Jun 05, 2019 at 11:01:17PM -0700, John Hubbard wrote: > I started reviewing this one patch, and it's kind of messy figuring out > if the code motion preserves everything because of > all the consolidation from other places, plus having to move things in > and out of the ifdef blocks. So I figured I'd check and see if this is > going to make it past RFC status soon, and if it's going before or after > Ira's recent RFC ("RDMA/FS DAX truncate proposal"). I don't like the huge moves either, but I can't really think of any better way to do it. Proposals welcome, though.