From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Date: Fri, 21 Jun 2019 13:40:21 +0000 Subject: Re: [PATCH 02/16] mm: simplify gup_fast_permitted Message-Id: <20190621134021.GM19891@ziepe.ca> List-Id: References: <20190611144102.8848-1-hch@lst.de> <20190611144102.8848-3-hch@lst.de> In-Reply-To: <20190611144102.8848-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: Linus Torvalds , Paul Burton , James Hogan , Yoshinori Sato , Rich Felker , "David S. Miller" , Nicholas Piggin , Khalid Aziz , Andrey Konovalov , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org On Tue, Jun 11, 2019 at 04:40:48PM +0200, Christoph Hellwig wrote: > Pass in the already calculated end value instead of recomputing it, and > leave the end > start check in the callers instead of duplicating them > in the arch code. > > Signed-off-by: Christoph Hellwig > --- > arch/s390/include/asm/pgtable.h | 8 +------- > arch/x86/include/asm/pgtable_64.h | 8 +------- > mm/gup.c | 17 +++++++---------- > 3 files changed, 9 insertions(+), 24 deletions(-) Much cleaner Reviewed-by: Jason Gunthorpe Jason