From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Fri, 09 Aug 2019 21:56:08 +0000 Subject: Re: [PATCH] sh: Drop -Werror from kernel Makefile Message-Id: <20190809215608.GA11065@roeck-us.net> List-Id: References: <1564971263-21562-1-git-send-email-linux@roeck-us.net> <20190805032441.GO9017@brightrain.aerifal.cx> <20190809195630.GA15606@roeck-us.net> <5f26547f-b48e-4b9f-b8ef-858283915e3d@embeddedor.com> In-Reply-To: <5f26547f-b48e-4b9f-b8ef-858283915e3d@embeddedor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Gustavo A. R. Silva" Cc: Rich Felker , Yoshinori Sato , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Aug 09, 2019 at 04:36:01PM -0500, Gustavo A. R. Silva wrote: > Hi Guenter, > > On 8/9/19 2:56 PM, Guenter Roeck wrote: > > On Sun, Aug 04, 2019 at 11:24:41PM -0400, Rich Felker wrote: > >> On Sun, Aug 04, 2019 at 07:14:23PM -0700, Guenter Roeck wrote: > >>> Since commit a035d552a93b ("Makefile: Globally enable fall-through > >>> warning"), all sh builds fail with errors such as > >>> > >>> arch/sh/kernel/disassemble.c: In function 'print_sh_insn': > >>> arch/sh/kernel/disassemble.c:478:8: error: this statement may fall through > >>> > >>> Since this effectively disables all build and boot tests for the > >>> architecture, let's drop -Werror from the sh kernel Makefile until > >>> the problems are fixed. > >>> > >>> Cc: Gustavo A. R. Silva > >>> Signed-off-by: Guenter Roeck > >> > >> Acked-by: Rich Felker > >> > > Any chance to get this or a similar patch applied soon ? All sh builds > > in mainline and -next are still broken. > > > > If no one cares, I can add it to my tree and include it in my pull-request > for 5.3-rc4. > > I would just need your Tested-by. > Sure: Tested-by: Guenter Roeck [ Applied to ToT and built sh:{defconfig,allnoconfig,tinyconfig} ] Thanks, Guenter > Thanks > -- > Gustavo > > > Thanks, > > Guenter > > > >>> --- > >>> arch/sh/kernel/Makefile | 2 -- > >>> 1 file changed, 2 deletions(-) > >>> > >>> diff --git a/arch/sh/kernel/Makefile b/arch/sh/kernel/Makefile > >>> index 59673f8a3379..ef65f0625c6c 100644 > >>> --- a/arch/sh/kernel/Makefile > >>> +++ b/arch/sh/kernel/Makefile > >>> @@ -47,5 +47,3 @@ obj-$(CONFIG_DWARF_UNWINDER) += dwarf.o > >>> obj-$(CONFIG_PERF_EVENTS) += perf_event.o perf_callchain.o > >>> obj-$(CONFIG_DMA_NONCOHERENT) += dma-coherent.o > >>> obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o > >>> - > >>> -ccflags-y := -Werror > >>> -- > >>> 2.7.4