From: Gon Solo <gonsolo@gmail.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>, Gon Solo <gonsolo@gmail.com>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/1] Fix undefined reference to 'node_reclaim_distance'.
Date: Mon, 16 Dec 2019 10:35:22 +0000 [thread overview]
Message-ID: <20191216103522.32215-2-gonsolo@gmail.com> (raw)
In-Reply-To: <20191216103522.32215-1-gonsolo@gmail.com>
According to https://lkml.org/lkml/2019/12/16/101 and
http://kisskb.ellerman.id.au/kisskb/buildresult/14067948/ building on
sh4 is broken due to a
page_alloc.c:(.text+0x3148): undefined reference to `node_reclaim_distance'.
This only happens with CONFIG_NUMA=y (variable used with #ifdef
CONFIG_NUMA at mm/page_alloc.c:3529) and CONFIG_SMP=n (variable defined at
kernel/sched/topology.c:2291 but the whole file to be built depends on
CONFIG_SMP in kernel/sched/Makefile:23.
Follow the lead of arch/x86/Kconfig:1547 and depend on SMP.
This assumes that there are no NUMA systems without SMP which is
reasonable I guess.
Signed-off-by: Gon Solo <gonsolo@gmail.com>
---
arch/sh/mm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/sh/mm/Kconfig b/arch/sh/mm/Kconfig
index 5c8a2ebfc720..cf655d8e8758 100644
--- a/arch/sh/mm/Kconfig
+++ b/arch/sh/mm/Kconfig
@@ -108,7 +108,7 @@ config VSYSCALL
config NUMA
bool "Non Uniform Memory Access (NUMA) Support"
- depends on MMU && SYS_SUPPORTS_NUMA
+ depends on MMU && SMP && SYS_SUPPORTS_NUMA
select ARCH_WANT_NUMA_VARIABLE_LOCALITY
default n
help
--
2.20.1
next prev parent reply other threads:[~2019-12-16 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 10:35 [PATCH 0/1] Fix SH config error Gon Solo
2019-12-16 10:35 ` Gon Solo [this message]
2019-12-16 12:21 ` [PATCH 1/1] Fix undefined reference to 'node_reclaim_distance' Geert Uytterhoeven
2019-12-16 13:21 ` Gonsolo
2019-12-16 13:31 ` Geert Uytterhoeven
2019-12-16 13:50 ` Gonsolo
2019-12-23 16:42 ` Matt Fleming
2019-12-25 7:18 ` Randy Dunlap
[not found] ` <CANL0fFTCVj7c-EQTs1kRuOn8e++vgFw1fUTJfya12csWkJdGqA@mail.gmail.com>
2020-05-04 12:08 ` Gonsolo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216103522.32215-2-gonsolo@gmail.com \
--to=gonsolo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dalias@libc.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).