From: Sam Ravnborg <sam@ravnborg.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] SH: Convert iounmap() macros to inline functions
Date: Tue, 17 Dec 2019 06:53:47 +0000 [thread overview]
Message-ID: <20191217065347.GA28172@ravnborg.org> (raw)
In-Reply-To: <87eex3h2g6.wl-kuninori.morimoto.gx@renesas.com>
Hi Kuninori
On Tue, Dec 17, 2019 at 03:48:57PM +0900, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Macro iounmap() do nothing, but that results in
> unused variable warnings all over the place.
> This patch convert it to inline to avoid warning
To help other people with the same warning it is always a good idea to
include the warning you fix in the changelog.
With this fixed:
Acked-by: Sam Ravnborg <sam@ravnborg.org>
>
> Fixes: 98c90e5ea34e9 ("sh: remove __iounmap")
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/sh/include/asm/io.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sh/include/asm/io.h b/arch/sh/include/asm/io.h
> index 1495489..351a0a9 100644
> --- a/arch/sh/include/asm/io.h
> +++ b/arch/sh/include/asm/io.h
> @@ -328,7 +328,7 @@ __ioremap_mode(phys_addr_t offset, unsigned long size, pgprot_t prot)
> #else
> #define __ioremap(offset, size, prot) ((void __iomem *)(offset))
> #define __ioremap_mode(offset, size, prot) ((void __iomem *)(offset))
> -#define iounmap(addr) do { } while (0)
> +static inline void iounmap(void __iomem *addr) {}
> #endif /* CONFIG_MMU */
>
> static inline void __iomem *ioremap(phys_addr_t offset, unsigned long size)
> --
> 2.7.4
next prev parent reply other threads:[~2019-12-17 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 6:48 [PATCH] SH: Convert iounmap() macros to inline functions Kuninori Morimoto
2019-12-17 6:53 ` Sam Ravnborg [this message]
2019-12-17 7:37 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217065347.GA28172@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox