From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Sun, 26 Jan 2020 15:11:37 +0000 Subject: Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implemen Message-Id: <20200126151137.C0CA8C43383@smtp.codeaurora.org> List-Id: References: <20200108200528.4614-3-krzk@kernel.org> In-Reply-To: <20200108200528.4614-3-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Krzysztof Kozlowski Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Alexey Brodkin , Vineet Gupta , "James E.J. Bottomley" , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Yoshinori Sato , Rich Felker , Dave Airlie , David Airlie , Daniel Vetter , Ben Skeggs , Mauro Carvalho Chehab , Jiri Slaby , Nick Kossifidis , Luis Krzysztof Kozlowski wrote: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Geert Uytterhoeven I assume this and patch 9 are going via some other tree so dropping them from my patchwork queue. -- https://patchwork.kernel.org/patch/11324461/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches