Re: [PATCH 8/8] perf/hw_breakpoint: Clean up headers

Dmitry Vyukov
2022-06-09T12:12:14Z

On Thu, 9 Jun 2022 at 13:31, Marco Elver <elver@google.com> wrote:
>
> Clean up headers:
>
> - Remove unused <linux/kallsyms.h>
>
> - Remove unused <linux/kprobes.h>
>
> - Remove unused <linux/module.h>
>
> - Remove unused <linux/smp.h>
>
> - Add <linux/export.h> for EXPORT_SYMBOL_GPL().
>
> - Sort alphabetically.
>
> - Move <linux/hw_breakpoint.h> to top to test it compiles on its own.
>
> Signed-off-by: Marco Elver <elver@google.com>

Acked-by: Dmitry Vyukov <dvyukov@google.com>

> ---
> kernel/events/hw_breakpoint.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c
> index 3b33a4075104..e9aa7f2c031a 100644
> --- a/kernel/events/hw_breakpoint.c
> +++ b/kernel/events/hw_breakpoint.c
> @@ -17,26 +17,24 @@
> * This file contains the arch-independent routines.
> */
>
> +#include <linux/hw_breakpoint.h>
> +
> #include <linux/atomic.h>
> +#include <linux/bug.h>
> +#include <linux/cpu.h>
> +#include <linux/export.h>
> +#include <linux/init.h>
> #include <linux/irqflags.h>
> -#include <linux/kallsyms.h>
> -#include <linux/notifier.h>
> -#include <linux/kprobes.h>
> #include <linux/kdebug.h>
> #include <linux/kernel.h>
> -#include <linux/module.h>
> #include <linux/mutex.h>
> +#include <linux/notifier.h>
> #include <linux/percpu.h>
> +#include <linux/rhashtable.h>
> #include <linux/sched.h>
> -#include <linux/spinlock.h>
> -#include <linux/init.h>
> #include <linux/slab.h>
> -#include <linux/rhashtable.h>
> -#include <linux/cpu.h>
> -#include <linux/smp.h>
> -#include <linux/bug.h>
> +#include <linux/spinlock.h>
>
> -#include <linux/hw_breakpoint.h>
> /*
> * Constraints data
> */
> --
> 2.36.1.255.ge46751e96f-goog
>