From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro
Date: Tue, 09 Apr 2013 17:07:40 +0000 [thread overview]
Message-ID: <2023317.YgggvpAYlv@avalon> (raw)
In-Reply-To: <878v4sb8y1.wl%kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Monday 08 April 2013 21:54:18 Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
> >> Laurent
>
> I guess this patch is correct on your macro idea ?
Yes it is.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> drivers/pinctrl/sh-pfc/pfc-r8a7779.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index 7ba1f21..53cf679 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -80,7 +80,7 @@
> #define _GP_PORT_ALL(bank, pin, name, sfx) name##_##sfx
>
> #define _GP_GPIO(bank, pin, _name, sfx) \
> - [(bank * 32) + pin] = { \
> + [RCAR_GP_PIN(bank, pin)] = { \
> .name = __stringify(_name), \
> .enum_id = _name##_DATA, \
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-09 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 4:54 [PATCH] sh-pfc: r8a7779: use RCAR_GP_PIN() on _GP_GPIO() macro Kuninori Morimoto
2013-04-09 17:07 ` Laurent Pinchart [this message]
2013-04-10 0:40 ` Simon Horman
2013-04-16 3:11 ` Simon Horman
2013-04-22 3:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023317.YgggvpAYlv@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox