From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3FF310A28 for ; Wed, 13 Mar 2024 03:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710299915; cv=none; b=JBT0/Jd6MXuCXoEewCKHohcMXyyaWs4T5v4N+/8ADzc8fzLjugRBnoUn4UFYuNxYY1IcjTN2fr1nxeSy2oiUGr42ospBmTa7KaQpAX3v7J8tLZX7XwQSMaEDx3/uaGh0cyHKFPYwwd3HcGzkltGHZX90sRf2UBG3r5DbpP3Ruc8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710299915; c=relaxed/simple; bh=DiuiKuasqVoMN5PUXSR4ob9TkaURBd7jOgolAmglw7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kxQ3X+DsCMePR4oxzV2stGz9YCNRW8xriMzvdl4QtCvzS8m4GD3hu/JMEP2sGxM2zO1IUPAXLyTnudb6lqsKZteZROIkumCtggi6XXYfj9JVvKEx4WgpHMPPWVoTaTgL64iRFdoeQhEcfsrMW/AkmSBgURQQvL1Qzb0vN/DzqNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=eGA9w2dG; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="eGA9w2dG" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6e6adf257fdso1067764b3a.0 for ; Tue, 12 Mar 2024 20:18:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1710299912; x=1710904712; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ErBpDoChwJS3Dz9w/fXRIf25+ofQNHhqhOBTpwuSEJ8=; b=eGA9w2dG6q1CQgb5Usjj+KJ7Bn7vKT0CT5NkdhpLTHrihdjZ04QxLhB6Lw4IXPVpFT MvxNWCpUtuLd3fGpQXbAcdpfdl0TT68oLyCBMtkHAQ1Uu14XZ045je9BUlPDWMSZt7Ci NQ6+OFbxxMUrqGfM9Bbwo7nhDvbeMdsY7eQC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710299912; x=1710904712; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ErBpDoChwJS3Dz9w/fXRIf25+ofQNHhqhOBTpwuSEJ8=; b=S8cCXc8Y3Ywj7gX1eykFvAFvTqljaAJR2Asjt13N7M6zlV/aQpqyOtow9SzWSWEQbG YKnvy4vaWGgx1Ubjr3uqLDtUy/NxhleFW3by4k3wl2yWY+cwvkXljfh7he/fvD04jWnc wNhd2xJcLUngecYpGkFzN0w0rMill1YzvUIqiDRSvbDcpoho7WLKkIS0lvizxemMqU0H GYYFGZoZYwHP7ty9U4ktRU8WwHZUsfz/DMuGrTOkaga87Y/oOtxQFcxKvI+3rauT69FP iPcwtstuUHLJTlegGjAUnMnDrsNsjUBHFJbhbw3Xs7IH0ZSrlf51SDUaElOK7isaG0OD DkFg== X-Forwarded-Encrypted: i=1; AJvYcCX+/grYlVid0I3jt9tMlvreFy7uA+MLM+xBqQdlBcWR6Ni2R9I3DNPn35BUc6dDH46HqVNES6BBp0mqbIFvUzKJFGFl+1HexYY= X-Gm-Message-State: AOJu0YwKng48PrvfGN2x3OG1C9zdb6Tl0KIk6gudjCj2Q7Yo3HKESOok 41QSQIvmXG04iT2kQKg0EvOYOYOsTVjXQL4sKKYLQOkvsY3TlIq6yb6tCwQRSQ== X-Google-Smtp-Source: AGHT+IFroIThZzohrORMRyBf4q2SfGniRe6Qp1geTDUSL9THSEZPoi4A4hryzimt0s4DNs3AfM3qQw== X-Received: by 2002:a05:6a00:181d:b0:6e5:d3b9:2d06 with SMTP id y29-20020a056a00181d00b006e5d3b92d06mr1621988pfa.21.1710299912048; Tue, 12 Mar 2024 20:18:32 -0700 (PDT) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id c1-20020aa78c01000000b006e697bd5285sm3892427pfd.203.2024.03.12.20.18.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 20:18:31 -0700 (PDT) Date: Tue, 12 Mar 2024 20:18:31 -0700 From: Kees Cook To: Rick Edgecombe Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, bp@alien8.de, broonie@kernel.org, dave.hansen@linux.intel.com, debug@rivosinc.com, hpa@zytor.com, kirill.shutemov@linux.intel.com, luto@kernel.org, mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de, x86@kernel.org, christophe.leroy@csgroup.eu, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v3 08/12] treewide: Use initializer for struct vm_unmapped_area_info Message-ID: <202403122018.DCCE1E000@keescook> References: <20240312222843.2505560-1-rick.p.edgecombe@intel.com> <20240312222843.2505560-9-rick.p.edgecombe@intel.com> Precedence: bulk X-Mailing-List: linux-sh@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240312222843.2505560-9-rick.p.edgecombe@intel.com> On Tue, Mar 12, 2024 at 03:28:39PM -0700, Rick Edgecombe wrote: > So to be reduce the chance of bugs via uninitialized fields, perform a > tree wide change using the consensus for the best general way to do this > change. Use C99 static initializing to zero the struct and remove and > statements that simply set members to zero. > > Signed-off-by: Rick Edgecombe Thanks! This looks to do exactly what it describes. :) Reviewed-by: Kees Cook -- Kees Cook