From: Mike Rapoport <rppt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Andreas Larsson <andreas@gaisler.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Dan Williams <dan.j.williams@intel.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
David Hildenbrand <david@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
Davidlohr Bueso <dave@stgolabs.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Carstens <hca@linux.ibm.com>,
Huacai Chen <chenhuacai@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Jonathan Corbet <corbet@lwn.net>,
Michael Ellerman <mpe@ellerman.id.au>,
Mike Rapoport <rppt@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Rob Herring <robh@kernel.org>,
Samuel Holland <samuel.holland@sifive.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vasily Gorbik <gor@linux.ibm.com>, Will Deacon <will@kernel.org>,
Zi Yan <ziy@nvidia.com>,
devicetree@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mips@vger.kernel.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
loongarch@lists.linux.dev, nvdimm@lists.linux.dev,
sparclinux@vger.kernel.org, x86@kernel.org
Subject: [PATCH v3 21/26] mm: numa_memblks: make several functions and variables static
Date: Thu, 1 Aug 2024 09:08:21 +0300 [thread overview]
Message-ID: <20240801060826.559858-22-rppt@kernel.org> (raw)
In-Reply-To: <20240801060826.559858-1-rppt@kernel.org>
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
Make functions and variables that are exclusively used by numa_memblks
static.
Move numa_nodemask_from_meminfo() before its callers to avoid forward
declaration.
Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Tested-by: Zi Yan <ziy@nvidia.com> # for x86_64 and arm64
---
include/linux/numa_memblks.h | 8 --------
mm/numa_memblks.c | 36 ++++++++++++++++++------------------
2 files changed, 18 insertions(+), 26 deletions(-)
diff --git a/include/linux/numa_memblks.h b/include/linux/numa_memblks.h
index 07381320848f..5c6e12ad0b7a 100644
--- a/include/linux/numa_memblks.h
+++ b/include/linux/numa_memblks.h
@@ -7,7 +7,6 @@
#define NR_NODE_MEMBLKS (MAX_NUMNODES * 2)
-extern int numa_distance_cnt;
void __init numa_set_distance(int from, int to, int distance);
void __init numa_reset_distance(void);
@@ -22,17 +21,10 @@ struct numa_meminfo {
struct numa_memblk blk[NR_NODE_MEMBLKS];
};
-extern struct numa_meminfo numa_meminfo __initdata_or_meminfo;
-extern struct numa_meminfo numa_reserved_meminfo __initdata_or_meminfo;
-
int __init numa_add_memblk(int nodeid, u64 start, u64 end);
void __init numa_remove_memblk_from(int idx, struct numa_meminfo *mi);
int __init numa_cleanup_meminfo(struct numa_meminfo *mi);
-int __init numa_register_meminfo(struct numa_meminfo *mi);
-
-void __init numa_nodemask_from_meminfo(nodemask_t *nodemask,
- const struct numa_meminfo *mi);
int __init numa_memblks_init(int (*init_func)(void),
bool memblock_force_top_down);
diff --git a/mm/numa_memblks.c b/mm/numa_memblks.c
index 7749b6f6b250..e97665a5e8ce 100644
--- a/mm/numa_memblks.c
+++ b/mm/numa_memblks.c
@@ -7,13 +7,27 @@
#include <linux/numa.h>
#include <linux/numa_memblks.h>
-int numa_distance_cnt;
+static int numa_distance_cnt;
static u8 *numa_distance;
nodemask_t numa_nodes_parsed __initdata;
-struct numa_meminfo numa_meminfo __initdata_or_meminfo;
-struct numa_meminfo numa_reserved_meminfo __initdata_or_meminfo;
+static struct numa_meminfo numa_meminfo __initdata_or_meminfo;
+static struct numa_meminfo numa_reserved_meminfo __initdata_or_meminfo;
+
+/*
+ * Set nodes, which have memory in @mi, in *@nodemask.
+ */
+static void __init numa_nodemask_from_meminfo(nodemask_t *nodemask,
+ const struct numa_meminfo *mi)
+{
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(mi->blk); i++)
+ if (mi->blk[i].start != mi->blk[i].end &&
+ mi->blk[i].nid != NUMA_NO_NODE)
+ node_set(mi->blk[i].nid, *nodemask);
+}
/**
* numa_reset_distance - Reset NUMA distance table
@@ -290,20 +304,6 @@ int __init numa_cleanup_meminfo(struct numa_meminfo *mi)
return 0;
}
-/*
- * Set nodes, which have memory in @mi, in *@nodemask.
- */
-void __init numa_nodemask_from_meminfo(nodemask_t *nodemask,
- const struct numa_meminfo *mi)
-{
- int i;
-
- for (i = 0; i < ARRAY_SIZE(mi->blk); i++)
- if (mi->blk[i].start != mi->blk[i].end &&
- mi->blk[i].nid != NUMA_NO_NODE)
- node_set(mi->blk[i].nid, *nodemask);
-}
-
/*
* Mark all currently memblock-reserved physical memory (which covers the
* kernel's own memory ranges) as hot-unswappable.
@@ -371,7 +371,7 @@ static void __init numa_clear_kernel_node_hotplug(void)
}
}
-int __init numa_register_meminfo(struct numa_meminfo *mi)
+static int __init numa_register_meminfo(struct numa_meminfo *mi)
{
int i;
--
2.43.0
next prev parent reply other threads:[~2024-08-01 6:12 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 6:08 [PATCH v3 00/26] mm: introduce numa_memblks Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 01/26] mm: move kernel/numa.c to mm/ Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 02/26] MIPS: sgi-ip27: make NODE_DATA() the same as on all other architectures Mike Rapoport
2024-08-01 17:44 ` Jonathan Cameron
2024-08-06 13:05 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 03/26] MIPS: sgi-ip27: ensure node_possible_map only contains valid nodes Mike Rapoport
2024-08-01 17:44 ` Jonathan Cameron
2024-08-06 13:05 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 04/26] MIPS: sgi-ip27: drop HAVE_ARCH_NODEDATA_EXTENSION Mike Rapoport
2024-08-01 17:45 ` Jonathan Cameron
2024-08-06 13:06 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 05/26] MIPS: loongson64: rename __node_data to node_data Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 06/26] MIPS: loongson64: drop HAVE_ARCH_NODEDATA_EXTENSION Mike Rapoport
2024-08-01 17:47 ` Jonathan Cameron
2024-08-06 13:07 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 07/26] mm: drop CONFIG_HAVE_ARCH_NODEDATA_EXTENSION Mike Rapoport
2024-08-02 9:49 ` Jonathan Cameron
2024-08-03 18:58 ` Andrew Morton
2024-08-04 7:24 ` Mike Rapoport
2024-08-04 15:11 ` Jonathan Cameron
2024-08-05 14:39 ` Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 08/26] arch, mm: move definition of node_data to generic code Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 09/26] arch, mm: pull out allocation of NODE_DATA " Mike Rapoport
2024-08-02 9:55 ` Jonathan Cameron
2024-08-05 17:15 ` Mike Rapoport
2024-08-01 6:08 ` [PATCH v3 10/26] x86/numa: simplify numa_distance allocation Mike Rapoport
2024-08-02 9:56 ` Jonathan Cameron
2024-08-06 13:08 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 11/26] x86/numa: use get_pfn_range_for_nid to verify that node spans memory Mike Rapoport
2024-08-02 10:36 ` Jonathan Cameron
2024-08-05 20:03 ` Dan Williams
2024-08-05 20:35 ` Mike Rapoport
2024-08-06 13:10 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 12/26] x86/numa: move FAKE_NODE_* defines to numa_emu Mike Rapoport
2024-08-06 13:10 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 13/26] x86/numa_emu: simplify allocation of phys_dist Mike Rapoport
2024-08-06 13:11 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 14/26] x86/numa_emu: split __apicid_to_node update to a helper function Mike Rapoport
2024-08-06 13:13 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 15/26] x86/numa_emu: use a helper function to get MAX_DMA32_PFN Mike Rapoport
2024-08-06 13:14 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 16/26] x86/numa: numa_{add,remove}_cpu: make cpu parameter unsigned Mike Rapoport
2024-08-06 13:14 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 17/26] mm: introduce numa_memblks Mike Rapoport
2024-08-02 10:49 ` Jonathan Cameron
2024-08-06 13:16 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 18/26] mm: move numa_distance and related code from x86 to numa_memblks Mike Rapoport
2024-08-02 10:52 ` Jonathan Cameron
2024-08-06 13:16 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 19/26] mm: introduce numa_emulation Mike Rapoport
2024-08-02 11:19 ` Jonathan Cameron
2024-08-05 20:09 ` Dan Williams
2024-08-06 13:18 ` David Hildenbrand
2024-08-06 13:20 ` David Hildenbrand
2024-08-06 13:24 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 20/26] mm: numa_memblks: introduce numa_memblks_init Mike Rapoport
2024-08-02 11:08 ` Jonathan Cameron
2024-08-06 13:21 ` David Hildenbrand
2024-08-01 6:08 ` Mike Rapoport [this message]
2024-08-02 11:10 ` [PATCH v3 21/26] mm: numa_memblks: make several functions and variables static Jonathan Cameron
2024-08-06 13:21 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 22/26] mm: numa_memblks: use memblock_{start,end}_of_DRAM() when sanitizing meminfo Mike Rapoport
2024-08-02 11:12 ` Jonathan Cameron
2024-08-05 20:21 ` Dan Williams
2024-08-05 20:33 ` Mike Rapoport
2024-08-06 13:22 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 23/26] of, numa: return -EINVAL when no numa-node-id is found Mike Rapoport
2024-08-02 14:01 ` Jonathan Cameron
2024-08-06 13:23 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 24/26] arch_numa: switch over to numa_memblks Mike Rapoport
2024-08-02 15:07 ` Jonathan Cameron
2024-08-06 13:28 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 25/26] mm: make range-to-target_node lookup facility a part of numa_memblks Mike Rapoport
2024-08-05 20:24 ` Dan Williams
2024-08-06 13:27 ` David Hildenbrand
2024-08-01 6:08 ` [PATCH v3 26/26] docs: move numa=fake description to kernel-parameters.txt Mike Rapoport
2024-08-02 15:09 ` Jonathan Cameron
2024-08-06 13:25 ` David Hildenbrand
2024-08-02 16:44 ` [PATCH v3 00/26] mm: introduce numa_memblks Jonathan Cameron
2024-08-05 19:41 ` Dan Williams
2024-08-05 20:26 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801060826.559858-22-rppt@kernel.org \
--to=rppt@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andreas@gaisler.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=david@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hca@linux.ibm.com \
--cc=jiaxun.yang@flygoat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nvdimm@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=samuel.holland@sifive.com \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).