From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A731B9B33; Thu, 1 Aug 2024 17:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722534299; cv=none; b=fG06FVucOrNgm9WGqCuI6SW8brqFBeW5ke7AdMcUNb/QfEBkZg1JMRsVmlLo1hjTDxdSd7FLdb5qLQLwIrqqtmFE1BVfbUKR1EAbkSfFkZzzskNZRKeMOYoeDjMMCzvE+QorKvpJTaQTqLGJ4o2dn95ncSRGjdlBKxJe80/r4go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722534299; c=relaxed/simple; bh=XUDiyEGqFfvzlgCPvvmqFQaNVf4VierLRzq2RkPNiSE=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pw43GfOl2YoOSBL9Vg4psfh2VBR4tpXZvrP6QUVaLBM5QcrARU5oeGSRwMltnEIKSyEfxr8c1r5mIF6m4gsSaBW+cHUdIpQEhqlCj5Zz81boC83U0cAZqk91i1pS84+cTwmEqe9flTeNNIQdyqWbZLXjIDbVa3b3040KOkgX/H8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4WZbrV0TrPz67WPF; Fri, 2 Aug 2024 01:42:18 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id 22E93140B55; Fri, 2 Aug 2024 01:44:54 +0800 (CST) Received: from localhost (10.203.177.66) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 1 Aug 2024 18:44:53 +0100 Date: Thu, 1 Aug 2024 18:44:52 +0100 From: Jonathan Cameron To: Mike Rapoport CC: , Alexander Gordeev , Andreas Larsson , "Andrew Morton" , Arnd Bergmann , "Borislav Petkov" , Catalin Marinas , Christophe Leroy , Dan Williams , Dave Hansen , David Hildenbrand , "David S. Miller" , Davidlohr Bueso , "Greg Kroah-Hartman" , Heiko Carstens , Huacai Chen , Ingo Molnar , Jiaxun Yang , "John Paul Adrian Glaubitz" , Jonathan Corbet , Michael Ellerman , Palmer Dabbelt , "Rafael J. Wysocki" , Rob Herring , Samuel Holland , Thomas Bogendoerfer , Thomas Gleixner , "Vasily Gorbik" , Will Deacon , Zi Yan , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 03/26] MIPS: sgi-ip27: ensure node_possible_map only contains valid nodes Message-ID: <20240801184452.00007d30@Huawei.com> In-Reply-To: <20240801060826.559858-4-rppt@kernel.org> References: <20240801060826.559858-1-rppt@kernel.org> <20240801060826.559858-4-rppt@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-sh@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) On Thu, 1 Aug 2024 09:08:03 +0300 Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > For SGI IP27 machines node_possible_map is statically set to > NODE_MASK_ALL and it is not updated during NUMA initialization. > > Ensure that it only contains nodes present in the system. > > Signed-off-by: Mike Rapoport (Microsoft) Reviewed-by: Jonathan Cameron > --- > arch/mips/sgi-ip27/ip27-smp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c > index 5d2652a1d35a..62733e049570 100644 > --- a/arch/mips/sgi-ip27/ip27-smp.c > +++ b/arch/mips/sgi-ip27/ip27-smp.c > @@ -70,11 +70,13 @@ void cpu_node_probe(void) > gda_t *gdap = GDA; > > nodes_clear(node_online_map); > + nodes_clear(node_possible_map); > for (i = 0; i < MAX_NUMNODES; i++) { > nasid_t nasid = gdap->g_nasidtable[i]; > if (nasid == INVALID_NASID) > break; > node_set_online(nasid); > + node_set(nasid, node_possible_map); > highest = node_scan_cpus(nasid, highest); > } >