From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] sh_eth: Convert to DEFINE_SIMPLE_DEV_PM_OPS()
Date: Fri, 5 Sep 2025 20:41:03 +0200 [thread overview]
Message-ID: <20250905184103.GA1887882@ragnatech.se> (raw)
In-Reply-To: <c1f6fb82-9188-48ed-9763-712afa71c481@lunn.ch>
On 2025-09-05 13:57:05 +0200, Andrew Lunn wrote:
> > You cannot enter system sleep without CONFIG_PM_SLEEP, so enabling
> > WoL would be pointless.
>
> Yet get_wol will return WoL can be used, and set_wol will allow you to
> configure it. It seems like EOPNOTSUPP would be better.
Out of curiosity. Are you suggesting a compile time check/construct for
CONFIG_PM_SLEEP be added in the driver itself, or in ethtool_set_wol()
and ethtool_get_wol() in net/ethtool/ioctl.c to complement the
if (!dev->ethtool_ops->get_wol || !dev->ethtool_ops->set_wol)
return -EOPNOTSUPP;
checks already there? To always return EOPNOTSUPP if PM_SLEEP is not
selected?
>
> Andrew
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2025-09-05 18:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 15:18 [PATCH net-next 0/3] sh_eth: PM-related cleanups Geert Uytterhoeven
2025-09-04 15:18 ` [PATCH net-next 1/3] sh_eth: Remove dummy Runtime PM callbacks Geert Uytterhoeven
2025-09-04 18:29 ` Andrew Lunn
2025-09-04 15:18 ` [PATCH net-next 2/3] sh_eth: Convert to DEFINE_SIMPLE_DEV_PM_OPS() Geert Uytterhoeven
2025-09-04 18:37 ` Andrew Lunn
2025-09-05 7:12 ` Geert Uytterhoeven
2025-09-05 11:57 ` Andrew Lunn
2025-09-05 18:41 ` Niklas Söderlund [this message]
2025-09-08 14:36 ` Geert Uytterhoeven
2025-09-08 16:18 ` Andrew Lunn
2025-09-29 8:26 ` Geert Uytterhoeven
2025-09-04 15:18 ` [PATCH net-next 3/3] sh_eth: Use async pm_runtime_put() Geert Uytterhoeven
2025-09-04 18:38 ` Andrew Lunn
2025-09-04 20:32 ` [PATCH net-next 0/3] sh_eth: PM-related cleanups Niklas Söderlund
2025-09-06 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250905184103.GA1887882@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).