From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Sat, 21 Apr 2012 14:30:36 +0000 Subject: Re: [PATCH 2/9] ARM: sh-mobile: mackerel: Add error IRQ resource Message-Id: <2098300.FxL39kQn7a@avalon> List-Id: References: <1334913230-23615-1-git-send-email-hechtb@gmail.com> <1334913230-23615-3-git-send-email-hechtb@gmail.com> In-Reply-To: <1334913230-23615-3-git-send-email-hechtb@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bastian Hecht Cc: Magnus Damm , linux-mtd@lists.infradead.org, linux-sh@vger.kernel.org Hi Bastian, Thanks for the patch. On Friday 20 April 2012 11:13:43 Bastian Hecht wrote: > Supply the platform data for the FLSTEI error IRQ. This should come before your 1/9 patch, otherwise the FLCTL driver will fail to get the IRQ, breaking git bisect. > Signed-off-by: Bastian Hecht > --- > arch/arm/mach-shmobile/board-mackerel.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-shmobile/board-mackerel.c > b/arch/arm/mach-shmobile/board-mackerel.c index 8758f94..1de1fb7 100644 > --- a/arch/arm/mach-shmobile/board-mackerel.c > +++ b/arch/arm/mach-shmobile/board-mackerel.c > @@ -990,7 +990,11 @@ static struct resource nand_flash_resources[] = { > .start = 0xe6a30000, > .end = 0xe6a3009b, > .flags = IORESOURCE_MEM, > - } > + }, > + [1] = { > + .start = evt2irq(0x0d80), /* flstei: status error irq */ > + .flags = IORESOURCE_IRQ, > + }, > }; > > static struct sh_flctl_platform_data nand_flash_data = { -- Regards, Laurent Pinchart