From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linus.walleij@linaro.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
SH-Linux <linux-sh@vger.kernel.org>,
linux-gpio <linux-gpio@vger.kernel.org>,
Simon Horman <horms@verge.net.au>
Subject: Re: [PATCH] gpio: rcar: Support both edge trigger with DT
Date: Thu, 28 Nov 2013 15:31:59 +0000 [thread overview]
Message-ID: <2124422.xP76KsfKRo@avalon> (raw)
In-Reply-To: <CANqRtoRhHhWp0zDcc8jN3eqV=O-=4uBG_a9Xb1-+Lk4eEiZoiw@mail.gmail.com>
Hi Linus,
On Thursday 14 November 2013 15:12:46 Magnus Damm wrote:
> On Thu, Nov 14, 2013 at 1:26 AM, Laurent Pinchart wrote:
> > Some versions of the R-Car GPIO controller support triggering on both
> > edges of the input signal. Whether this capability is supported is
> > currently specified in platform data. R-Car GPIO devices instantiated
> > from the device tree have the capability turned off even when the
> > hardware supports it.
> >
> > To fix this, add DT match data support to the driver, initialize both
> > edge trigger support from match data and enable both edge trigger in
> > r8a7790 and r8a7791 match data.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > drivers/gpio/gpio-rcar.c | 56 +++++++++++++++++++++++++++++++++----------
> > 1 file changed, 43 insertions(+), 13 deletions(-)
>
> Looks fine to me, thanks!
>
> Acked-by: Magnus Damm <damm@opensource.se>
Could you please pick this patch up for v3.14 ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-11-28 15:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 16:26 [PATCH] gpio: rcar: Support both edge trigger with DT Laurent Pinchart
2013-11-14 6:12 ` Magnus Damm
2013-11-28 15:31 ` Laurent Pinchart [this message]
2013-11-29 12:23 ` Linus Walleij
2013-11-15 4:43 ` David Cohen
2013-11-17 0:57 ` Laurent Pinchart
2013-11-17 2:38 ` David Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2124422.xP76KsfKRo@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=horms@verge.net.au \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).