From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 28 Nov 2013 15:31:59 +0000 Subject: Re: [PATCH] gpio: rcar: Support both edge trigger with DT Message-Id: <2124422.xP76KsfKRo@avalon> List-Id: References: <1384359983-29178-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linus.walleij@linaro.org Cc: Magnus Damm , Laurent Pinchart , SH-Linux , linux-gpio , Simon Horman Hi Linus, On Thursday 14 November 2013 15:12:46 Magnus Damm wrote: > On Thu, Nov 14, 2013 at 1:26 AM, Laurent Pinchart wrote: > > Some versions of the R-Car GPIO controller support triggering on both > > edges of the input signal. Whether this capability is supported is > > currently specified in platform data. R-Car GPIO devices instantiated > > from the device tree have the capability turned off even when the > > hardware supports it. > > > > To fix this, add DT match data support to the driver, initialize both > > edge trigger support from match data and enable both edge trigger in > > r8a7790 and r8a7791 match data. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpio/gpio-rcar.c | 56 +++++++++++++++++++++++++++++++++---------- > > 1 file changed, 43 insertions(+), 13 deletions(-) > > Looks fine to me, thanks! > > Acked-by: Magnus Damm Could you please pick this patch up for v3.14 ? -- Regards, Laurent Pinchart