From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: r8a7779: Don't group USB OVC and PENC pins
Date: Tue, 07 May 2013 15:16:51 +0000 [thread overview]
Message-ID: <2165023.iIgNqWDicN@avalon> (raw)
In-Reply-To: <1367908563-20293-1-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Sergei,
On Tuesday 07 May 2013 19:09:53 Sergei Shtylyov wrote:
> On 07-05-2013 18:51, Laurent Pinchart wrote:
[snip]
> >>> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> >>> b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c index d6056ed..ddc2b2e 100644
> >>> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> >>> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> >>> @@ -2392,27 +2392,48 @@ static const unsigned int sdhi3_wp_mux[] = {
> >>>
> >>> };
> >>> /* - USB0
> >>> -------------------------------------------------------------------
> >>> */
> >>> static const unsigned int usb0_pins[] = {
> >>>
> >>> - /* OVC */
> >>> - RCAR_GP_PIN(4, 22), RCAR_GP_PIN(4, 26),
> >>> + /* PENC */
> >>>
> >> PENC0.
> >
> > It's the PENC pin for the USB0 function, so the comments refer to PENC,
> > not PENC0. Same for the other pins below.
>
> No, the other pins are not the same: there's OVCn and USB_OVCn pins, you're
> mixing them up in your other comments.
I will s/OVC/USB_OVC/
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-05-07 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 6:36 [PATCH] sh-pfc: r8a7779: Don't group USB OVC and PENC pins Laurent Pinchart
2013-05-07 12:01 ` Sergei Shtylyov
2013-05-07 14:51 ` Laurent Pinchart
2013-05-07 15:09 ` Sergei Shtylyov
2013-05-07 15:16 ` Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-05-25 6:45 [GIT PULL] Renesas ARM based SoC pinmux fix for v3.10 (repost) Simon Horman
2013-05-25 6:45 ` [PATCH] sh-pfc: r8a7779: Don't group USB OVC and PENC pins Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2165023.iIgNqWDicN@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox