* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
@ 2014-10-25 15:07 ` Laurent Pinchart
2014-10-27 0:36 ` Kuninori Morimoto
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2014-10-25 15:07 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Tuesday 22 July 2014 19:42:55 Kuninori Morimoto wrote:
> Hi Laurent
>
> These are sound DMA support platform side patches.
> These worked well when it was based on shdma-base
> driver base.
>
> These are including all sound DMA supports,
> but, it is too much for cyclic transfer test.
I'm trying to test cyclic DMA support in the rcar-dmac driver using this patch
series.
I've applied all the patches on top of a merge of asoc/topic/rcar, renesas-
drivers-2014-10-23-v3.18-rc1 and Simon's latest master branch. The sound
devices are not probed correctly:
[ 10.720000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.730000] sh_mobile_sdhi ee100000.sd: mmc1 base at 0xee100000 clock rate
97 MHz
[ 10.730000] i2c-sh_mobile e6510000.i2c: I2C adapter 5 with bus speed 100000
Hz (L/H=0x145/0x118)
[ 10.730000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.750000] rcar_sound ec500000.rcar_sound: Failed to create debugfs
directory
[ 10.750000] rcar_sound ec500000.rcar_sound: Failed to create debugfs
directory
[ 10.750000] rcar_sound ec500000.rcar_sound: Failed to create debugfs
directory
[ 10.760000] rcar_sound ec500000.rcar_sound: probed
[ 10.760000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 10.760000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.770000] i2c-sh_mobile e6520000.i2c: I2C adapter 6 with bus speed 100000
Hz (L/H=0x145/0x118)
[ 10.770000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 10.770000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.800000] DA9210: 1000 mV at 4600 mA
[ 10.800000] i2c-sh_mobile e60b0000.i2c: I2C adapter 7 with bus speed 100000
Hz (L/H=0x19/0x16)
[ 10.800000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 10.800000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.860000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 10.870000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.880000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 10.890000] platform sound: Driver asoc-simple-card requests probe deferral
[ 10.910000] random: nonblocking pool is initialized
[ 11.060000] sh_mobile_sdhi ee140000.sd: mmc2 base at 0xee140000 clock rate
48 MHz
[ 11.060000] asoc-simple-card sound: ASoC: CPU DAI rsnd-dai.0 not registered
[ 11.070000] platform sound: Driver asoc-simple-card requests probe deferral
Am I missing something ? Is there a newer version of the Lager audio + DMA
support patches ?
> I guess 1/3/5/6/10/11/ are enough.
>
> Current rcar-dmac filter can't care "dma0" or "audma0" now.
> So, I disabled "dma0/1" as quick-hack.
>
> &dmac0 {
> status = "disabled";
> };
>
> &dmac1 {
> status = "disabled";
> };
>
> I could get short sound if I modified driver as try-and-error.
> (and it dead after that, of course it is wrong fix)
> So, I guess, address/IRQ/MID-RID/MSTP/etc settings are correct.
>
> If you have alsa command, you need this
>
> > amixer set "LINEOUT Mixer DACL" on
> > aplay xxx.wav
>
> I used...
>
> > git checkout renesas-drivers-2014-07-11-v3.16-rc4
> > git merge asoc/topic/rcar
>
> # asoc = git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
>
> Kuninori Morimoto (11):
> 1) ARM: shmobile: r8a7790: Add Audio DMAC devices to DT
> 2) ARM: shmobile: r8a7790: Add Audio DMAC peri peri devices to DT
> 3) ARM: shmobile: r8a7790: sound enables Audio DMAC entry on DTSI
> 4) ARM: shmobile: r8a7790: sound enables Audio DMAC peri peri entry
> on DTSI
> 5) ARM: shmobile: lager: Sound PIO support on DTS
> 6) ARM: shmobile: lager: Sound DMA support on DTS
> 7) ARM: shmobile: lager: Sound DMA support via BUSIF on DTS
> 8) ARM: shmobile: lager: Sound DMA support via SRC on DTS
> 9) ARM: shmobile: lager: Sound DMA support via DVC on DTS
> 10) ARM: shmobile: multiplatform: add Audo DMAC peri peri support on
> defconfig
> 11) ARM: shmobile: multiplatform: add R-Car DMAC support on
> defconfig
>
> arch/arm/boot/dts/r8a7790-lager.dts | 66 ++++++++++
> arch/arm/boot/dts/r8a7790.dtsi | 203 +++++++++++++++++++++++++-
> arch/arm/configs/shmobile_defconfig | 2 +
> arch/arm/mach-shmobile/Kconfig | 1 +
> include/dt-bindings/clock/r8a7790-clock.h | 2 +
> 5 files changed, 271 insertions(+), 3 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
2014-10-25 15:07 ` Laurent Pinchart
@ 2014-10-27 0:36 ` Kuninori Morimoto
2014-10-27 12:48 ` Laurent Pinchart
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-27 0:36 UTC (permalink / raw)
To: linux-sh
Hi Laurent
Thank you for contacting me
> > These are sound DMA support platform side patches.
> > These worked well when it was based on shdma-base
> > driver base.
> >
> > These are including all sound DMA supports,
> > but, it is too much for cyclic transfer test.
>
> I'm trying to test cyclic DMA support in the rcar-dmac driver using this patch
> series.
>
> I've applied all the patches on top of a merge of asoc/topic/rcar, renesas-
> drivers-2014-10-23-v3.18-rc1 and Simon's latest master branch. The sound
> devices are not probed correctly:
(snip)
> Am I missing something ? Is there a newer version of the Lager audio + DMA
> support patches ?
Sorry, driver had a bug, and I fixed it on latest upstream.
Can you add below on my previous patch series ?
It should be probed.
------------------
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index 950a438..d6e7efd 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -166,7 +166,7 @@
simple-audio-card,frame-master = <&sndcodec>;
sndcpu: simple-audio-card,cpu {
- sound-dai = <&rcar_sound 0>;
+ sound-dai = <&rcar_sound>;
};
sndcodec: simple-audio-card,codec {
@@ -474,6 +474,8 @@
pinctrl-0 = <&sound_pins &sound_clk_pins>;
pinctrl-names = "default";
+ #sound-dai-cells = <0>;
+
status = "okay";
rcar_sound,dai {
------------------
Best regards
---
Kuninori Morimoto
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
2014-10-25 15:07 ` Laurent Pinchart
2014-10-27 0:36 ` Kuninori Morimoto
@ 2014-10-27 12:48 ` Laurent Pinchart
2014-10-28 0:16 ` Kuninori Morimoto
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2014-10-27 12:48 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Sunday 26 October 2014 17:36:12 Kuninori Morimoto wrote:
> Hi Laurent
>
> Thank you for contacting me
>
> > > These are sound DMA support platform side patches.
> > > These worked well when it was based on shdma-base
> > > driver base.
> > >
> > > These are including all sound DMA supports,
> > > but, it is too much for cyclic transfer test.
> >
> > I'm trying to test cyclic DMA support in the rcar-dmac driver using this
> > patch series.
> >
> > I've applied all the patches on top of a merge of asoc/topic/rcar,
> > renesas-
> > drivers-2014-10-23-v3.18-rc1 and Simon's latest master branch. The sound
>
> > devices are not probed correctly:
> (snip)
>
> > Am I missing something ? Is there a newer version of the Lager audio + DMA
> > support patches ?
>
> Sorry, driver had a bug, and I fixed it on latest upstream.
> Can you add below on my previous patch series ?
> It should be probed.
That fixed the probe issue, thank you. Do you plan to push this change to
Simon's tree ?
With this patch applied I've been able to test audio playback and get it to
fail :-) The first problem is caused by GFP_KERNEL allocation in the prep
cyclic handler in shdma-base.c. I've sent a patch to fix that and have CC'ed
you.
The next failure comes from the call to pm_runtime_get() in shdma_tx_submit():
rcar-audmapp-engine ec740000.audio-dma-pp: shdma_tx_submit(): GET = -13
rcar_sound ec500000.rcar_sound: status check failed
rcar_sound ec500000.rcar_sound: status check failed
Is that a known problem ?
> ------------------
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index 950a438..d6e7efd 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -166,7 +166,7 @@
> simple-audio-card,frame-master = <&sndcodec>;
>
> sndcpu: simple-audio-card,cpu {
> - sound-dai = <&rcar_sound 0>;
> + sound-dai = <&rcar_sound>;
> };
>
> sndcodec: simple-audio-card,codec {
> @@ -474,6 +474,8 @@
> pinctrl-0 = <&sound_pins &sound_clk_pins>;
> pinctrl-names = "default";
>
> + #sound-dai-cells = <0>;
> +
> status = "okay";
>
> rcar_sound,dai {
> ------------------
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (2 preceding siblings ...)
2014-10-27 12:48 ` Laurent Pinchart
@ 2014-10-28 0:16 ` Kuninori Morimoto
2014-10-28 20:59 ` Laurent Pinchart
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-28 0:16 UTC (permalink / raw)
To: linux-sh
Hi Laurent
> That fixed the probe issue, thank you. Do you plan to push this change to
> Simon's tree ?
Current Simon's tree doesn't have board support yet.
This means no one (= except you :) have trouble in upstream.
But, yes, I will fix it when I send sound board support patch-set.
> With this patch applied I've been able to test audio playback and get it to
> fail :-) The first problem is caused by GFP_KERNEL allocation in the prep
> cyclic handler in shdma-base.c. I've sent a patch to fix that and have CC'ed
> you.
>
> The next failure comes from the call to pm_runtime_get() in shdma_tx_submit():
>
> rcar-audmapp-engine ec740000.audio-dma-pp: shdma_tx_submit(): GET = -13
> rcar_sound ec500000.rcar_sound: status check failed
> rcar_sound ec500000.rcar_sound: status check failed
GET = -13 is because PeriPeri doesn't have MSTP bit,
but it is message/warning only.
status check failed seems DMA doesn't work (?)
it seems similar with my known issue which was this
http://www.spinics.net/lists/dmaengine/msg01525.html
especially 1) issue ?
Kuninori Morimoto (11):
1) ARM: shmobile: r8a7790: Add Audio DMAC devices to DT
2) ARM: shmobile: r8a7790: Add Audio DMAC peri peri devices to DT
3) ARM: shmobile: r8a7790: sound enables Audio DMAC entry on DTSI
4) ARM: shmobile: r8a7790: sound enables Audio DMAC peri peri entry on DTSI
5) ARM: shmobile: lager: Sound PIO support on DTS
6) ARM: shmobile: lager: Sound DMA support on DTS
7) ARM: shmobile: lager: Sound DMA support via BUSIF on DTS
8) ARM: shmobile: lager: Sound DMA support via SRC on DTS
9) ARM: shmobile: lager: Sound DMA support via DVC on DTS
10) ARM: shmobile: multiplatform: add Audo DMAC peri peri support on defconfig
11) ARM: shmobile: multiplatform: add R-Car DMAC support on defconfig
I'm sorry that I didn't explain about sound.
I guess you are using soud FULL feature now (= 1 to 11), and,
this means your kernel is using Audio DMAC + PeriPeri DMAC.
But, very basic sound doesn't need PeriPeri DMAC.
Can you use 1) - 6) patches (and previous fixup patch) ?
7) / 8) / 9) requests PeriPeri DMAC, and problem will be more complex.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (3 preceding siblings ...)
2014-10-28 0:16 ` Kuninori Morimoto
@ 2014-10-28 20:59 ` Laurent Pinchart
2014-10-29 0:08 ` Kuninori Morimoto
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2014-10-28 20:59 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Monday 27 October 2014 17:16:16 Kuninori Morimoto wrote:
> Hi Laurent
>
> > That fixed the probe issue, thank you. Do you plan to push this change to
> > Simon's tree ?
>
> Current Simon's tree doesn't have board support yet.
> This means no one (= except you :) have trouble in upstream.
Indeed :-)
> But, yes, I will fix it when I send sound board support patch-set.
By the way, when you submit "ARM: shmobile: r8a7790: Add Audio DMAC devices to
DT", you might want to s/contorller/controller/ in r8a7790.dts.
> > With this patch applied I've been able to test audio playback and get it
> > to fail :-) The first problem is caused by GFP_KERNEL allocation in the
> > prep cyclic handler in shdma-base.c. I've sent a patch to fix that and
> > have CC'ed you.
> >
> > The next failure comes from the call to pm_runtime_get() in
> > shdma_tx_submit():
> >
> > rcar-audmapp-engine ec740000.audio-dma-pp: shdma_tx_submit(): GET = -13
> > rcar_sound ec500000.rcar_sound: status check failed
> > rcar_sound ec500000.rcar_sound: status check failed
>
> GET = -13 is because PeriPeri doesn't have MSTP bit,
> but it is message/warning only.
>
> status check failed seems DMA doesn't work (?)
> it seems similar with my known issue which was this
>
> http://www.spinics.net/lists/dmaengine/msg01525.html
>
> especially 1) issue ?
>
> Kuninori Morimoto (11):
> 1) ARM: shmobile: r8a7790: Add Audio DMAC devices to DT
> 2) ARM: shmobile: r8a7790: Add Audio DMAC peri peri devices to DT
> 3) ARM: shmobile: r8a7790: sound enables Audio DMAC entry on DTSI
> 4) ARM: shmobile: r8a7790: sound enables Audio DMAC peri peri entry
> on DTSI 5) ARM: shmobile: lager: Sound PIO support on DTS
> 6) ARM: shmobile: lager: Sound DMA support on DTS
> 7) ARM: shmobile: lager: Sound DMA support via BUSIF on DTS
> 8) ARM: shmobile: lager: Sound DMA support via SRC on DTS
> 9) ARM: shmobile: lager: Sound DMA support via DVC on DTS
> 10) ARM: shmobile: multiplatform: add Audo DMAC peri peri support on
> defconfig 11) ARM: shmobile: multiplatform: add R-Car DMAC support on
> defconfig
>
> I'm sorry that I didn't explain about sound.
> I guess you are using soud FULL feature now (= 1 to 11), and,
> this means your kernel is using Audio DMAC + PeriPeri DMAC.
> But, very basic sound doesn't need PeriPeri DMAC.
>
> Can you use 1) - 6) patches (and previous fixup patch) ?
> 7) / 8) / 9) requests PeriPeri DMAC, and problem will be more complex.
That gets rid of the runtime PM issue, but I then get a status check failed
when trying to play audio and no audio or DMA interrupt seem to be generated:
root@arago:~# cat /proc/interrupts > irq.1
root@arago:~# time aplay audiodump.wav
Playing WAVE 'audiodump.wav' : Signed 16 bit Little Endian, Rate 44100 Hz,
Stereo
aplay: pcm_write:1528: write error: Input/output error
[ 89.710000] rcar_sound ec500000.rcar_sound: status check failed
[ 89.710000] rcar_sound ec500000.rcar_sound: status check failed
Command exited with non-zero status 1
real 0m 10.15s
user 0m 0.09s
sys 0m 0.04s
root@arago:~# cat /proc/interrupts > irq.2
$ diff -u irq.1 irq.2
--- irq.1 2014-10-28 22:47:21.725420047 +0200
+++ irq.2 2014-10-28 22:47:37.143421188 +0200
@@ -1,5 +1,5 @@
CPU0 CPU1 CPU2 CPU3
- 27: 1127 3105 668 731 GIC 27 arch_timer
+ 27: 1216 3148 732 772 GIC 27 arch_timer
32: 1 0 0 0 GIC 32
e61c0000.interrupt-controller
33: 0 0 0 0 GIC 33
e61c0000.interrupt-controller
34: 0 0 0 0 GIC 34
e61c0000.interrupt-controller
@@ -11,11 +11,11 @@
40: 0 0 0 0 GIC 40 e6054000.gpio
41: 0 0 0 0 GIC 41 e6055000.gpio
174: 0 0 0 0 GIC 174
ffca0000.timer
-176: 716 0 0 0 GIC 176
e6c40000.serial:mux
-194: 10459 0 0 0 GIC 194 eth0
+176: 795 0 0 0 GIC 176
e6c40000.serial:mux
+194: 10788 0 0 0 GIC 194 eth0
205: 28 0 0 0 GIC 205 e60b0000.i2c
206: 0 0 0 0 GIC 206 e6500000.i2c
-207: 120 0 0 0 GIC 207 e6510000.i2c
+207: 199 0 0 0 GIC 207 e6510000.i2c
208: 0 0 0 0 GIC 208 e6520000.i2c
229: 0 0 0 0 GIC 229 e6700000.dma-
controller:error
232: 0 0 0 0 GIC 232 e6700000.dma-
controller:0
@@ -84,7 +84,7 @@
420: 0 0 0 0 e6051000.gpio 28 SW2-4
IPI0: 0 0 0 0 CPU wakeup interrupts
IPI1: 0 0 0 0 Timer broadcast interrupts
-IPI2: 774 886 834 901 Rescheduling interrupts
+IPI2: 776 904 860 915 Rescheduling interrupts
IPI3: 23 13 25 13 Function call interrupts
IPI4: 0 0 0 0 Single function call
interrupts
IPI5: 0 0 0 0 CPU stop interrupts
I can't hear any sound being output (just for confirmation, is the audio
output port the bottom connector ?).
As I don't have amixer installed on my rootfs the problem might also be
related to the output being muted. Do you know in which state it starts by
default ?
I've pushed my test branch to
git://linuxtv.org/pinchartl/fbdev.git dma/audio
It doesn't include support for DMA hardware descriptors yet, as I wanted to
rule out any issue with them.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (4 preceding siblings ...)
2014-10-28 20:59 ` Laurent Pinchart
@ 2014-10-29 0:08 ` Kuninori Morimoto
2014-10-29 1:33 ` Kuninori Morimoto
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-29 0:08 UTC (permalink / raw)
To: linux-sh
Hi Laurent
> By the way, when you submit "ARM: shmobile: r8a7790: Add Audio DMAC devices to
> DT", you might want to s/contorller/controller/ in r8a7790.dts.
Ohh my...
It never happens if I can use Japanese comment in patch :P
> That gets rid of the runtime PM issue, but I then get a status check failed
> when trying to play audio and no audio or DMA interrupt seem to be generated:
(snip)
> I can't hear any sound being output (just for confirmation, is the audio
> output port the bottom connector ?).
>
> As I don't have amixer installed on my rootfs the problem might also be
> related to the output being muted. Do you know in which state it starts by
> default ?
>
> I've pushed my test branch to
>
> git://linuxtv.org/pinchartl/fbdev.git dma/audio
>
> It doesn't include support for DMA hardware descriptors yet, as I wanted to
> rule out any issue with them.
Thank you for pushing your test branch.
I will check it.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (5 preceding siblings ...)
2014-10-29 0:08 ` Kuninori Morimoto
@ 2014-10-29 1:33 ` Kuninori Morimoto
2014-10-29 14:08 ` Laurent Pinchart
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-29 1:33 UTC (permalink / raw)
To: linux-sh
Hi Laurent again
Thank you for your DMA cyclic work
> > I've pushed my test branch to
> >
> > git://linuxtv.org/pinchartl/fbdev.git dma/audio
> >
> > It doesn't include support for DMA hardware descriptors yet, as I wanted to
> > rule out any issue with them.
Unfortunately, it was patch applying magic.
ak4643 is needed under iic2, not iic1.
Can you add attached patch on your dma/audio branch ?
It works for me.
When you use sound on Lager board, you need amixer setting.
And you can use bottom jack of CN17 for sound output.
/ # amixer set "LINEOUT Mixer DACL" on
/* start sound playback and check DMA interrupt */
/ # aplay /home/xxx.wav &
/ # grep dma /proc/interrupts
...
352: 103 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 124 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 146 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 195 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 216 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 239 0 0 0 GIC 352 ec700000.dma-contorller:0
/* stop sound playback and check DMA interrupt */
/ # fg
aplay /home/Calm_16bit_48k.wav
^CAborted by signal Interrupt...
/ # grep dma /proc/interrupts
...
352: 280 0 0 0 GIC 352 ec700000.dma-contorller:0
/ # grep dma /proc/interrupts
...
352: 280 0 0 0 GIC 352 ec700000.dma-contorller:0
----------------------
diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts
index f891a00..03fe43a 100644
--- a/arch/arm/boot/dts/r8a7790-lager.dts
+++ b/arch/arm/boot/dts/r8a7790-lager.dts
@@ -409,12 +409,6 @@
status = "ok";
pinctrl-0 = <&iic1_pins>;
pinctrl-names = "default";
-
- ak4643: sound_codec {
- compatible = "asahi-kasei,ak4643";
- #sound-dai-cells = <0>;
- reg = <0x12>;
- };
};
&iic2 {
@@ -434,6 +428,12 @@
};
};
};
+
+ ak4643: sound_codec {
+ compatible = "asahi-kasei,ak4643";
+ #sound-dai-cells = <0>;
+ reg = <0x12>;
+ };
};
&iic3 {
----------------------
Best regards
---
Kuninori Morimoto
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (6 preceding siblings ...)
2014-10-29 1:33 ` Kuninori Morimoto
@ 2014-10-29 14:08 ` Laurent Pinchart
2014-10-30 0:07 ` Kuninori Morimoto
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2014-10-29 14:08 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Tuesday 28 October 2014 18:33:38 Kuninori Morimoto wrote:
> Hi Laurent again
>
> Thank you for your DMA cyclic work
>
> > > I've pushed my test branch to
> > >
> > > git://linuxtv.org/pinchartl/fbdev.git dma/audio
> > >
> > > It doesn't include support for DMA hardware descriptors yet, as I wanted
> > > to rule out any issue with them.
>
> Unfortunately, it was patch applying magic.
> ak4643 is needed under iic2, not iic1.
> Can you add attached patch on your dma/audio branch ?
>
> It works for me.
> When you use sound on Lager board, you need amixer setting.
> And you can use bottom jack of CN17 for sound output.
>
> / # amixer set "LINEOUT Mixer DACL" on
After applying your patch and setting the control I get sound ! I'll now test
and debug hardware descriptors support.
Thank you for your help.
> /* start sound playback and check DMA interrupt */
>
> / # aplay /home/xxx.wav &
> / # grep dma /proc/interrupts
> ...
> 352: 103 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 124 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 146 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 195 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 216 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 239 0 0 0 GIC 352
> ec700000.dma-contorller:0
>
> /* stop sound playback and check DMA interrupt */
>
> / # fg
> aplay /home/Calm_16bit_48k.wav
> ^CAborted by signal Interrupt...
> / # grep dma /proc/interrupts
> ...
> 352: 280 0 0 0 GIC 352
> ec700000.dma-contorller:0 / # grep dma /proc/interrupts
> ...
> 352: 280 0 0 0 GIC 352
> ec700000.dma-contorller:0
>
> ----------------------
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index f891a00..03fe43a 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -409,12 +409,6 @@
> status = "ok";
> pinctrl-0 = <&iic1_pins>;
> pinctrl-names = "default";
> -
> - ak4643: sound_codec {
> - compatible = "asahi-kasei,ak4643";
> - #sound-dai-cells = <0>;
> - reg = <0x12>;
> - };
> };
>
> &iic2 {
> @@ -434,6 +428,12 @@
> };
> };
> };
> +
> + ak4643: sound_codec {
> + compatible = "asahi-kasei,ak4643";
> + #sound-dai-cells = <0>;
> + reg = <0x12>;
> + };
> };
>
> &iic3 {
> ----------------------
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (7 preceding siblings ...)
2014-10-29 14:08 ` Laurent Pinchart
@ 2014-10-30 0:07 ` Kuninori Morimoto
2014-10-30 0:46 ` Laurent Pinchart
2014-10-30 1:28 ` Kuninori Morimoto
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-30 0:07 UTC (permalink / raw)
To: linux-sh
Hi Laurent, Magnus
> > > > I've pushed my test branch to
> > > >
> > > > git://linuxtv.org/pinchartl/fbdev.git dma/audio
> > > >
> > > > It doesn't include support for DMA hardware descriptors yet, as I wanted
> > > > to rule out any issue with them.
> >
> > Unfortunately, it was patch applying magic.
> > ak4643 is needed under iic2, not iic1.
> > Can you add attached patch on your dma/audio branch ?
> >
> > It works for me.
> > When you use sound on Lager board, you need amixer setting.
> > And you can use bottom jack of CN17 for sound output.
> >
> > / # amixer set "LINEOUT Mixer DACL" on
>
> After applying your patch and setting the control I get sound ! I'll now test
> and debug hardware descriptors support.
Nice !
I thik "normal" cyclic is OK on this driver now.
Are all patches which are required for cyclic posted to ML ?
I'm asking because ...
- I want to send sound support patch
- LTSI 3.14 backport want to use it.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (8 preceding siblings ...)
2014-10-30 0:07 ` Kuninori Morimoto
@ 2014-10-30 0:46 ` Laurent Pinchart
2014-10-30 1:28 ` Kuninori Morimoto
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2014-10-30 0:46 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Wednesday 29 October 2014 17:07:20 Kuninori Morimoto wrote:
> Hi Laurent, Magnus
>
> >>>> I've pushed my test branch to
> >>>>
> >>>> git://linuxtv.org/pinchartl/fbdev.git dma/audio
> >>>>
> >>>> It doesn't include support for DMA hardware descriptors yet, as I
> >>>> wanted to rule out any issue with them.
> >>
> >> Unfortunately, it was patch applying magic.
> >> ak4643 is needed under iic2, not iic1.
> >> Can you add attached patch on your dma/audio branch ?
> >>
> >> It works for me.
> >> When you use sound on Lager board, you need amixer setting.
> >> And you can use bottom jack of CN17 for sound output.
> >>
> >> / # amixer set "LINEOUT Mixer DACL" on
> >
> > After applying your patch and setting the control I get sound ! I'll now
> > test and debug hardware descriptors support.
>
> Nice !
> I thik "normal" cyclic is OK on this driver now.
> Are all patches which are required for cyclic posted to ML ?
> I'm asking because ...
> - I want to send sound support patch
> - LTSI 3.14 backport want to use it.
I've just send the latest version of the rcar-dmac patches to the dmaengine
and linux-sh mailing list, CC'ing you. They include hardware descriptor list
and cyclic transfer support. I've tested them with your audio patches (I've
just pushed my test branch to git://linuxtv.org/pinchartl/fbdev.git
dma/audio).
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/11][RFC] sound DMA support patches
2014-07-23 2:42 [PATCH 0/11][RFC] sound DMA support patches Kuninori Morimoto
` (9 preceding siblings ...)
2014-10-30 0:46 ` Laurent Pinchart
@ 2014-10-30 1:28 ` Kuninori Morimoto
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2014-10-30 1:28 UTC (permalink / raw)
To: linux-sh
Hi Laurent
> > I thik "normal" cyclic is OK on this driver now.
> > Are all patches which are required for cyclic posted to ML ?
> > I'm asking because ...
> > - I want to send sound support patch
> > - LTSI 3.14 backport want to use it.
>
> I've just send the latest version of the rcar-dmac patches to the dmaengine
> and linux-sh mailing list, CC'ing you. They include hardware descriptor list
> and cyclic transfer support. I've tested them with your audio patches (I've
> just pushed my test branch to git://linuxtv.org/pinchartl/fbdev.git
> dma/audio).
Thank you !
I will check it, and will post sound support patches to ML
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread