From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: bonito: Fix compile breakage
Date: Wed, 29 Feb 2012 20:29:33 +0000 [thread overview]
Message-ID: <2227428.A4iueEQo4g@avalon> (raw)
In-Reply-To: <1330523184-8540-1-git-send-email-phil.edworthy@renesas.com>
Hi Phil,
Thanks for the patch.
On Wednesday 29 February 2012 13:46:24 Phil Edworthy wrote:
> arch/arm/mach-shmobile/board-bonito.c:244:3: error: unknown field 'bpp'
> specified in initializer make[2]: ***
> [arch/arm/mach-shmobile/board-bonito.o] Error 1
>
> caused by commit "fbdev: sh_mobile_lcdc: Support FOURCC-based format API"
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
You were faster than me :-)
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> arch/arm/mach-shmobile/board-bonito.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/board-bonito.c
> b/arch/arm/mach-shmobile/board-bonito.c index 4d22016..4bd1162 100644
> --- a/arch/arm/mach-shmobile/board-bonito.c
> +++ b/arch/arm/mach-shmobile/board-bonito.c
> @@ -27,6 +27,7 @@
> #include <linux/platform_device.h>
> #include <linux/gpio.h>
> #include <linux/smsc911x.h>
> +#include <linux/videodev2.h>
> #include <mach/common.h>
> #include <asm/mach-types.h>
> #include <asm/mach/arch.h>
> @@ -241,7 +242,7 @@ static struct sh_mobile_lcdc_info lcdc0_info = {
> .clock_source = LCDC_CLK_BUS,
> .ch[0] = {
> .chan = LCDC_CHAN_MAINLCD,
> - .bpp = 16,
> + .fourcc = V4L2_PIX_FMT_RGB565,
> .interface_type = RGB24,
> .clock_divider = 5,
> .flags = 0,
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2012-02-29 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 13:46 [PATCH] sh: bonito: Fix compile breakage Phil Edworthy
2012-02-29 20:29 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2227428.A4iueEQo4g@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox