linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [kbuild] [slave-dma:for-linus 55/57] drivers/dma/sh/rcar-hpbdma.c:627:10-15: ERROR: iterator var
Date: Mon, 02 Jun 2014 11:09:32 +0000	[thread overview]
Message-ID: <2296161.9WoPSnLurk@avalon> (raw)

Hi,

On Monday 02 June 2014 10:33:42 Dan Carpenter wrote:
> tree:   git://git.infradead.org/users/vkoul/slave-dma.git for-linus
> head:   654fa24965aafcb4bb8a1a14400c5ecea3be76b6
> commit: ebc6d2d9c8cd48c351da84dd467c0edddc149ded [55/57] dmaengine: shdma:
> Enable driver compilation with COMPILE_TEST
> >> drivers/dma/sh/rcar-hpbdma.c:627:10-15: ERROR: iterator variable bound on
> >> line 626 cannot be NULL
> --
> >> drivers/dma/sh/shdma-base.c:812:7-12: ERROR: iterator variable bound on
> >> line 808 cannot be NULL
> --
> >> drivers/dma/sh/shdmac.c:581:10-15: ERROR: iterator variable bound on line
> >> 580 cannot be NULL
> --
> >> drivers/dma/sh/sudmac.c:303:10-15: ERROR: iterator variable bound on line
> >> 302 cannot be NULL
>
> Please consider folding the attached diff :-)

The shdma_for_each_chan iterator can in theory iterate over NULL elements. 
I'll need to check whether it can happen in practice before applying the 
proposed fixes.

-- 
Regards,

Laurent Pinchart


             reply	other threads:[~2014-06-02 11:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02 11:09 Laurent Pinchart [this message]
2014-06-02 11:26 ` [kbuild] [slave-dma:for-linus 55/57] drivers/dma/sh/rcar-hpbdma.c:627:10-15: ERROR: iterator var Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2296161.9WoPSnLurk@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).