From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: armadillo800eva: tidyup ST1232 pin settings
Date: Wed, 24 Jul 2013 09:58:45 +0000 [thread overview]
Message-ID: <2439753.x4g5oclBBG@avalon> (raw)
In-Reply-To: <87fw7w38mf.wl%kuninori.morimoto.gx@renesas.com>
Hi Morimoto-san,
On Wednesday 24 July 2013 17:16:12 Kuninori Morimoto wrote:
> 89ae7b5bbd3e65bc6ab7a577ca5ec18569589c8c
> (ARM: shmobile: armadillo800eva: Register pinctrl mapping for INTC)
> adds gpio request for 166pin, but it will be requested from
> st1232 driver itself via st1232_pdata :: reset_gpio.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>
> >> Simon, Hiep-san, Laurent
>
> Could you please check this patch ?
>
> arch/arm/mach-shmobile/board-armadillo800eva.c | 3 ---
> 1 file changed, 3 deletions(-)
Oops, I've submitted an identical patch that I had in my tree before seeing
yours. That probably means the code is correct, and it implies my Acked-by :-)
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c
> b/arch/arm/mach-shmobile/board-armadillo800eva.c index 2412fca..4cfcbbe
> 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -1205,9 +1205,6 @@ static void __init eva_init(void)
> /* LCDC0 */
> gpio_request_one(61, GPIOF_OUT_INIT_HIGH, NULL); /* LCDDON */
>
> - /* Touchscreen */
> - gpio_request_one(166, GPIOF_OUT_INIT_HIGH, NULL); /* TP_RST_B */
> -
> /* GETHER */
> gpio_request_one(18, GPIOF_OUT_INIT_HIGH, NULL); /* PHY_RST */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-07-24 9:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 6:03 [PATCH] ARM: shmobile: armadillo800eva: fixup: sound card detection order Kuninori Morimoto
2012-08-27 8:48 ` Simon Horman
2012-08-31 6:33 ` Simon Horman
2012-09-03 6:06 ` [PATCH] ARM: shmobile: armadillo800eva: enable rw rootfs mount Kuninori Morimoto
2012-09-03 8:34 ` Simon Horman
2012-09-13 3:10 ` [PATCH] ARM: shmobile: armadillo800eva: Add support RTC Nobuhiro Iwamatsu
2012-09-13 4:06 ` Simon Horman
2012-09-13 5:11 ` Nobuhiro Iwamatsu
2012-10-12 1:24 ` [PATCH] ARM: shmobile: armadillo800eva: __io abuse cleanup Kuninori Morimoto
2012-10-12 1:39 ` [PATCH] ARM: shmobile: armadillo800eva: enable restart Kuninori Morimoto
2012-10-12 4:25 ` Simon Horman
2012-10-12 4:32 ` [PATCH] ARM: shmobile: armadillo800eva: __io abuse cleanup Simon Horman
2013-01-18 5:02 ` [PATCH] ARM: shmobile: armadillo800eva: set clock rates before timer init Hideki EIRAKU
2013-01-18 6:28 ` Kuninori Morimoto
2013-01-30 4:23 ` Simon Horman
2013-04-15 4:44 ` [PATCH] arm: shmobile: armadillo800eva: Fix maximum number of SCIF Nobuhiro Iwamatsu
2013-04-16 2:35 ` Simon Horman
2013-07-02 15:24 ` [PATCH] ARM: shmobile: armadillo800eva: add DMA support to MMCIF Guennadi Liakhovetski
2013-07-03 6:05 ` Simon Horman
2013-07-24 8:16 ` [PATCH] ARM: shmobile: armadillo800eva: tidyup ST1232 pin settings Kuninori Morimoto
2013-07-24 9:58 ` Laurent Pinchart [this message]
2013-07-25 0:50 ` [PATCH] ARM: shmobile: armadillo800eva: Don't request GPIO 166 in board code Kuninori Morimoto
2013-12-18 14:03 ` [PATCH] ARM: shmobile: armadillo800eva: Enable backlight control in defconfig Laurent Pinchart
2013-12-19 6:13 ` Simon Horman
2014-04-14 0:59 ` [PATCH] ARM: shmobile: armadillo800eva: fixup SND_SOC_DAIFMT_CBx_CFx flags Kuninori Morimoto
2014-04-14 3:48 ` Simon Horman
2014-05-28 2:57 ` [PATCH] ARM: shmobile: armadillo800eva: fixup HDMI sound flags setting Kuninori Morimoto
2014-05-28 4:06 ` Simon Horman
2014-05-28 4:23 ` Kuninori Morimoto
2014-05-28 4:41 ` Simon Horman
2014-05-28 8:47 ` Geert Uytterhoeven
2014-08-11 2:38 ` [PATCH] ARM: shmobile: armadillo800eva: Sort includes Simon Horman
2014-08-22 1:47 ` Simon Horman
2014-09-02 1:16 ` Simon Horman
2014-09-24 0:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2439753.x4g5oclBBG@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox