From mboxrd@z Thu Jan 1 00:00:00 1970 From: Randy Dunlap Date: Sun, 22 Jul 2018 17:24:58 +0000 Subject: Re: [PATCH] arch/h8300: fix kernel/dma.c build warning Message-Id: <24723dd8-9d9f-24b7-6fe9-71a776c5d444@infradead.org> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Geert Uytterhoeven Cc: Richard Kuo , "open list:QUALCOMM HEXAGON..." , Linux Kernel Mailing List , Yoshinori Sato , Rich Felker , Linux-sh list On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > CC hexagon > > hexagon != H8/300 != SuperH argh. Thanks. > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: >> >> From: Randy Dunlap >> >> Fix build warning in arch/hexagon/kernel/dma.c by casting a void * >> to unsigned long to match the function parameter type. >> >> ../arch/hexagon/kernel/dma.c: In function 'arch_dma_alloc': >> ../arch/hexagon/kernel/dma.c:51:5: warning: passing argument 2 of 'gen_pool_add' makes integer from pointer without a cast [enabled by default] >> ../include/linux/genalloc.h:112:19: note: expected 'long unsigned int' but argument is of type 'void *' >> >> Signed-off-by: Randy Dunlap >> Cc: Yoshinori Sato >> Cc: Rich Felker >> Cc: linux-sh@vger.kernel.org >> --- >> arch/hexagon/kernel/dma.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- linux-next-20180717.orig/arch/hexagon/kernel/dma.c >> +++ linux-next-20180717/arch/hexagon/kernel/dma.c >> @@ -47,7 +47,7 @@ void *arch_dma_alloc(struct device *dev, >> panic("Can't create %s() memory pool!", __func__); >> else >> gen_pool_add(coherent_pool, >> - pfn_to_virt(max_low_pfn), >> + (unsigned long)pfn_to_virt(max_low_pfn), >> hexagon_coherent_pool_size, -1); >> } >> > > Gr{oetje,eeting}s, > > Geert > -- ~Randy