From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Fri, 14 Mar 2014 08:20:35 +0000 Subject: Re: [PATCH v2 1/2] ARM: shmobile: r8a7779: Use clks as MSTP007 parent Message-Id: <2475718.tNWNF9Ap5s@avalon> List-Id: References: <1394783739-29168-1-git-send-email-horms+renesas@verge.net.au> <1394783739-29168-2-git-send-email-horms+renesas@verge.net.au> In-Reply-To: <1394783739-29168-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Simon Horman Cc: Mark Brown , linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm Hi Simon, Thank you for the patch. On Friday 14 March 2014 16:55:38 Simon Horman wrote: > According to the documentation the parent clock of > MSTP007 should be clks not clkp. > > Cc: Laurent Pinchart > Signed-off-by: Simon Horman Acked-by: Laurent Pinchart > > --- > > v2 > * First post, as suggested by Laurent Pinchart > --- > arch/arm/mach-shmobile/clock-r8a7778.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-shmobile/clock-r8a7778.c > b/arch/arm/mach-shmobile/clock-r8a7778.c index 2009a9b..9989b1b 100644 > --- a/arch/arm/mach-shmobile/clock-r8a7778.c > +++ b/arch/arm/mach-shmobile/clock-r8a7778.c > @@ -170,7 +170,7 @@ static struct clk mstp_clks[MSTP_NR] = { > [MSTP010] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 10, 0), /* SSI2 */ > [MSTP009] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 9, 0), /* SSI3 */ > [MSTP008] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 8, 0), /* SRU */ > - [MSTP007] = SH_CLK_MSTP32(&p_clk, MSTPCR0, 7, 0), /* HSPI */ > + [MSTP007] = SH_CLK_MSTP32(&s_clk, MSTPCR0, 7, 0), /* HSPI */ > }; > > static struct clk_lookup lookups[] = { -- Regards, Laurent Pinchart