linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] clk: shmobile: add missing 0x0100 for SDCKCR
Date: Tue, 05 Aug 2014 09:06:58 +0000	[thread overview]
Message-ID: <2533034.O1mfuWNL4j@avalon> (raw)
In-Reply-To: <87ppgf1kgv.wl%kuninori.morimoto.gx@gmail.com>

Hi Morimoto-san,

Thank you for the patch.

On Tuesday 05 August 2014 00:09:26 Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Current cpg_sd01_div_table is missing
> "0x0100: x 1/8" division ratio.
> This patch is based on R-Car H2 v0.7, R-Car M2 v0.9.
> 
> Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> >> Simon
> 
> Actually,
> 	linux/arch/arm/mach-shmobile/clock-r8a7790.c : div4_clks
> 	linux/arch/arm/mach-shmobile/clock-r8a7791.c : div4_clks
> have same issue, but I ignored
> 
>  drivers/clk/shmobile/clk-rcar-gen2.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/shmobile/clk-rcar-gen2.c
> b/drivers/clk/shmobile/clk-rcar-gen2.c index dff7f79..e996425 100644
> --- a/drivers/clk/shmobile/clk-rcar-gen2.c
> +++ b/drivers/clk/shmobile/clk-rcar-gen2.c
> @@ -202,6 +202,7 @@ static const struct clk_div_table cpg_sdh_div_table[] > { };
> 
>  static const struct clk_div_table cpg_sd01_div_table[] = {
> +	{  4,  8 },
>  	{  5, 12 }, {  6, 16 }, {  7, 18 }, {  8, 24 },
>  	{ 10, 36 }, { 11, 48 }, { 12, 10 }, {  0,  0 },
>  };

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2014-08-05  9:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-05  7:09 [PATCH] clk: shmobile: add missing 0x0100 for SDCKCR Kuninori Morimoto
2014-08-05  7:17 ` Simon Horman
2014-08-05  7:25 ` Geert Uytterhoeven
2014-08-05  8:51 ` Kuninori Morimoto
2014-08-05  8:57 ` Kuninori Morimoto
2014-08-05  9:06 ` Laurent Pinchart [this message]
2014-08-06  0:32 ` Simon Horman
2014-08-06  0:39 ` Kuninori Morimoto
2014-08-06  1:29 ` Simon Horman
2014-08-06  1:32 ` Kuninori Morimoto
2014-08-06  1:41 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2533034.O1mfuWNL4j@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).