From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Tue, 18 Jun 2013 12:31:58 +0000 Subject: Re: [PATCH] clocksource: sh_cmt: Use devm_* managed helpers Message-Id: <2566074.m8COktZgTy@avalon> List-Id: References: <1371553171-23530-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sachin Kamat Cc: Laurent Pinchart , linux-sh@vger.kernel.org, Magnus Damm , linux-kernel@vger.kernel.org, Thomas Gleixner , John Stultz Hi Sachin, On Tuesday 18 June 2013 17:13:37 Sachin Kamat wrote: > On 18 June 2013 16:29, Laurent Pinchart wrote: > > This simplifies the main error path by getting rid of it. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/clocksource/sh_cmt.c | 40 ++++++++++++++------------------------- > > 1 file changed, 14 insertions(+), 26 deletions(-) > > > > The patch is based on top of renesas-next-20130618 plus Magnus' > > "clocksource: sh_cmt: 32-bit control register support" patch. > > > > diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c > > index 0965e98..7001e4d 100644 > > --- a/drivers/clocksource/sh_cmt.c > > +++ b/drivers/clocksource/sh_cmt.c [snip] > > @@ -703,23 +701,23 @@ static int sh_cmt_setup(struct sh_cmt_priv *p, > > struct platform_device *pdev)> > > irq = platform_get_irq(p->pdev, 0); > > if (irq < 0) { > > dev_err(&p->pdev->dev, "failed to get irq\n"); > > - goto err0; > > + return -ENXIO; > > } > > > > /* map memory, let mapbase point to our channel */ > > - p->mapbase = ioremap_nocache(res->start, resource_size(res)); > > + p->mapbase = devm_ioremap_resource(&pdev->dev, res); > > if (p->mapbase = NULL) { > > You should check for IS_ERR (p->mapbase) and return PTR_ERR(p->mapbase) > > > dev_err(&p->pdev->dev, "failed to remap I/O memory\n"); > > This error message is not required as devm_ioremap_resource prints its own. Oops, my bad. I'll fix that and resubmit. -- Regards, Laurent Pinchart