From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
Date: Tue, 08 Oct 2013 20:59:05 +0000 [thread overview]
Message-ID: <2589075.PaovHFAcbL@avalon> (raw)
In-Reply-To: <878uy9259u.wl%kuninori.morimoto.gx@renesas.com>
Hi Simon,
On Tuesday 08 October 2013 13:00:59 Simon Horman wrote:
> On Mon, Oct 07, 2013 at 07:57:06PM -0700, Kuninori Morimoto wrote:
> > Hi Simon
> >
> > > > > > > Kuninori Morimoto (7):
> > > > > > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > > > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > > > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > > > > 4) ARM: shmobile: bockw: remove manual PFC settings on
> > > > > > > reference
> > > > > > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > > > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > > > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> >
> > (snip)
> >
> > > > "ARM: shmobile: r8a7778: Fix pin control device address in DT" is
> > > > bugfix patch for DT. The kernel (especially, pfc settings = #3)
> > > > doesn't work without it. Is this explain enough for you ?
> > >
> > > Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
> > > DT" is not applied. When the pfc settings don't work does the kernel
> > > still
> > > work as well as it did prior to patch #3 not being applied?
> >
> > #1, #2 will works well without fixup patch.
>
> I will see about queuing up #1 and #2 without further delay.
>
> > #3 need it, and
> > #4-#7 need #3 patch.
>
> Thanks, I understand.
>
> Laurent, could you let me know if you have a branch available with "ARM:
> shmobile: r8a7778: Fix pin control device address in DT". If not I'm happy
> to wait.
I don't have one. The bug got introduced in v3.12-rc1, without any serious
consequence as the DT node wasn't used. The fix might even break the bockw-
reference board if Morimoto-san's patch 4 isn't applied, as the PFC device
seems to be registered twice then (I haven't tested this).
Morimoto-san, could you please test my fix on bockw-reference without your
patch series ? If it doesn't break anything then we could push it to v3.12.
Otherwise we can include it with this series. Simon, would that be fine with
you ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-10-08 20:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
2013-10-04 1:30 ` Kuninori Morimoto
2013-10-04 1:35 ` Kuninori Morimoto
2013-10-08 1:11 ` Simon Horman
2013-10-08 1:32 ` Kuninori Morimoto
2013-10-08 2:07 ` Simon Horman
2013-10-08 2:57 ` Kuninori Morimoto
2013-10-08 4:00 ` Simon Horman
2013-10-08 20:59 ` Laurent Pinchart [this message]
2013-10-09 0:11 ` Kuninori Morimoto
2013-10-09 20:20 ` Laurent Pinchart
2013-10-10 11:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2589075.PaovHFAcbL@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).