From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Tue, 08 Oct 2013 20:59:05 +0000
Subject: Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
Message-Id: <2589075.PaovHFAcbL@avalon>
List-Id: <linux-sh.vger.kernel.org>
References: <878uy9259u.wl%kuninori.morimoto.gx@renesas.com>
In-Reply-To: <878uy9259u.wl%kuninori.morimoto.gx@renesas.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: linux-sh@vger.kernel.org

Hi Simon,

On Tuesday 08 October 2013 13:00:59 Simon Horman wrote:
> On Mon, Oct 07, 2013 at 07:57:06PM -0700, Kuninori Morimoto wrote:
> > Hi Simon
> > 
> > > > > > > Kuninori Morimoto (7):
> > > > > > >       1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > > > >       2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > > > >       3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > > > >       4) ARM: shmobile: bockw: remove manual PFC settings on
> > > > > > >       reference
> > > > > > >       5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > > > >       6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > > > >       7) ARM: shmobile: bockw: add MMCIF support on DTS
> > 
> > (snip)
> > 
> > > > "ARM: shmobile: r8a7778: Fix pin control device address in DT" is
> > > > bugfix patch for DT. The kernel (especially, pfc settings = #3)
> > > > doesn't work without it. Is this explain enough for you ?
> > > 
> > > Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
> > > DT" is not applied. When the pfc settings don't work does the kernel
> > > still
> > > work as well as it did prior to patch #3 not being applied?
> > 
> > #1, #2 will works well without fixup patch.
> 
> I will see about queuing up #1 and #2 without further delay.
> 
> > #3 need it, and
> > #4-#7 need #3 patch.
> 
> Thanks, I understand.
> 
> Laurent, could you let me know if you have a branch available with "ARM:
> shmobile: r8a7778: Fix pin control device address in DT". If not I'm happy
> to wait.

I don't have one. The bug got introduced in v3.12-rc1, without any serious 
consequence as the DT node wasn't used. The fix might even break the bockw-
reference board if Morimoto-san's patch 4 isn't applied, as the PFC device 
seems to be registered twice then (I haven't tested this).

Morimoto-san, could you please test my fix on bockw-reference without your 
patch series ? If it doesn't break anything then we could push it to v3.12. 
Otherwise we can include it with this series. Simon, would that be fine with 
you ?

-- 
Regards,

Laurent Pinchart