From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Sat, 05 Dec 2015 22:20:35 +0000 Subject: Re: [PATCH v2 17/32] v4l: vsp1: Fix typo in VI6_DISP_IRQ_STA_DST register name Message-Id: <2694247.f6vaztlhDB@avalon> List-Id: References: <1449281586-25726-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1449281586-25726-18-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <56635B69.3000800@cogentembedded.com> In-Reply-To: <56635B69.3000800@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sergei Shtylyov Cc: Laurent Pinchart , linux-media@vger.kernel.org, linux-sh@vger.kernel.org Hi Sergio, On Sunday 06 December 2015 00:47:21 Sergei Shtylyov wrote: > On 12/5/2015 5:12 AM, Laurent Pinchart wrote: > > Rename the VI6_DISP_IRQ_STA_DSE register > > Register bit, perhaps? Indeed. I know I can count on you to catch even such small issues :-) I'll fix it for the next version (or the pull request if no issue that require a new review round is found). > > to VI6_DISP_IRQ_STA_DST to fix > > a typo and match the datasheet. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/media/platform/vsp1/vsp1_regs.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h > > b/drivers/media/platform/vsp1/vsp1_regs.h index > > 25b48738b147..8173ceaab9f9 100644 > > --- a/drivers/media/platform/vsp1/vsp1_regs.h > > +++ b/drivers/media/platform/vsp1/vsp1_regs.h > > @@ -46,7 +46,7 @@ > > > > #define VI6_DISP_IRQ_ENB_LNEE(n) (1 << (n)) > > > > #define VI6_DISP_IRQ_STA 0x007c > > > > -#define VI6_DISP_IRQ_STA_DSE (1 << 8) > > +#define VI6_DISP_IRQ_STA_DST (1 << 8) > > > > #define VI6_DISP_IRQ_STA_MAE (1 << 5) > > #define VI6_DISP_IRQ_STA_LNE(n) (1 << (n)) > > MBR, Sergei -- Regards, Laurent Pinchart