* [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins
@ 2013-05-31 15:57 Ulrich Hecht
2013-06-11 7:52 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Ulrich Hecht @ 2013-05-31 15:57 UTC (permalink / raw)
To: linux-sh
These pins are not actually connected on the board, but at least they
don't conflict with anything else.
Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
---
arch/arm/mach-shmobile/board-lager.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
index 1e99b17..d8bd237 100644
--- a/arch/arm/mach-shmobile/board-lager.c
+++ b/arch/arm/mach-shmobile/board-lager.c
@@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
/* SCIF1 (CN20: DEBUG SERIAL1) */
PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
"scif1_data", "scif1"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790",
+ "hscif0_data", "hscif0"),
+ PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790",
+ "hscif1_data_b", "hscif1"),
};
static void __init lager_add_standard_devices(void)
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins
2013-05-31 15:57 [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins Ulrich Hecht
@ 2013-06-11 7:52 ` Simon Horman
2013-06-12 14:08 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-06-11 7:52 UTC (permalink / raw)
To: linux-sh
On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote:
> These pins are not actually connected on the board, but at least they
> don't conflict with anything else.
I am holding off on queueing-up this patch pending a review of
[PATCH v3 3/5] sh-pfc: r8a7790: add HSCIF pin groups
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> ---
> arch/arm/mach-shmobile/board-lager.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index 1e99b17..d8bd237 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
> @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
> /* SCIF1 (CN20: DEBUG SERIAL1) */
> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> "scif1_data", "scif1"),
> + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790",
> + "hscif0_data", "hscif0"),
> + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790",
> + "hscif1_data_b", "hscif1"),
> };
>
> static void __init lager_add_standard_devices(void)
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins
2013-05-31 15:57 [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins Ulrich Hecht
2013-06-11 7:52 ` Simon Horman
@ 2013-06-12 14:08 ` Simon Horman
2013-06-14 16:51 ` Laurent Pinchart
2013-06-17 2:20 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-06-12 14:08 UTC (permalink / raw)
To: linux-sh
On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote:
> These pins are not actually connected on the board, but at least they
> don't conflict with anything else.
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
Thanks, I have queued this up in the pinmux branch.
> ---
> arch/arm/mach-shmobile/board-lager.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
> index 1e99b17..d8bd237 100644
> --- a/arch/arm/mach-shmobile/board-lager.c
> +++ b/arch/arm/mach-shmobile/board-lager.c
> @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
> /* SCIF1 (CN20: DEBUG SERIAL1) */
> PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> "scif1_data", "scif1"),
> + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790",
> + "hscif0_data", "hscif0"),
> + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790",
> + "hscif1_data_b", "hscif1"),
> };
>
> static void __init lager_add_standard_devices(void)
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins
2013-05-31 15:57 [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins Ulrich Hecht
2013-06-11 7:52 ` Simon Horman
2013-06-12 14:08 ` Simon Horman
@ 2013-06-14 16:51 ` Laurent Pinchart
2013-06-17 2:20 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Laurent Pinchart @ 2013-06-14 16:51 UTC (permalink / raw)
To: linux-sh
Hi Ulrich ans Simon,
On Wednesday 12 June 2013 23:08:47 Simon Horman wrote:
> On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote:
> > These pins are not actually connected on the board, but at least they
> > don't conflict with anything else.
That's actually not true, the hscif0_data pins are used by the DU RGB output.
If the HSCIF0 and HSCIF1 are not wired on the board I don't think they should
be added to the pinctrl maps.
Simon, should we revert this patch now or later when I'll submit DU patches
for Lager ?
> > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
>
> Thanks, I have queued this up in the pinmux branch.
>
> > ---
> >
> > arch/arm/mach-shmobile/board-lager.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/mach-shmobile/board-lager.c
> > b/arch/arm/mach-shmobile/board-lager.c index 1e99b17..d8bd237 100644
> > --- a/arch/arm/mach-shmobile/board-lager.c
> > +++ b/arch/arm/mach-shmobile/board-lager.c
> > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
> >
> > /* SCIF1 (CN20: DEBUG SERIAL1) */
> > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> >
> > "scif1_data", "scif1"),
> >
> > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790",
> > + "hscif0_data", "hscif0"),
> > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790",
> > + "hscif1_data_b", "hscif1"),
> >
> > };
> >
> > static void __init lager_add_standard_devices(void)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins
2013-05-31 15:57 [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins Ulrich Hecht
` (2 preceding siblings ...)
2013-06-14 16:51 ` Laurent Pinchart
@ 2013-06-17 2:20 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-06-17 2:20 UTC (permalink / raw)
To: linux-sh
On Fri, Jun 14, 2013 at 06:51:38PM +0200, Laurent Pinchart wrote:
> Hi Ulrich ans Simon,
>
> On Wednesday 12 June 2013 23:08:47 Simon Horman wrote:
> > On Fri, May 31, 2013 at 05:57:05PM +0200, Ulrich Hecht wrote:
> > > These pins are not actually connected on the board, but at least they
> > > don't conflict with anything else.
>
> That's actually not true, the hscif0_data pins are used by the DU RGB output.
>
> If the HSCIF0 and HSCIF1 are not wired on the board I don't think they should
> be added to the pinctrl maps.
>
> Simon, should we revert this patch now or later when I'll submit DU patches
> for Lager ?
I will simply drop this patch for now.
I can pick it up again if you and Ulrich decide that is the best course of
action.
> > > Signed-off-by: Ulrich Hecht <ulrich.hecht@gmail.com>
> >
> > Thanks, I have queued this up in the pinmux branch.
> >
> > > ---
> > >
> > > arch/arm/mach-shmobile/board-lager.c | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/arch/arm/mach-shmobile/board-lager.c
> > > b/arch/arm/mach-shmobile/board-lager.c index 1e99b17..d8bd237 100644
> > > --- a/arch/arm/mach-shmobile/board-lager.c
> > > +++ b/arch/arm/mach-shmobile/board-lager.c
> > > @@ -77,6 +77,10 @@ static const struct pinctrl_map lager_pinctrl_map[] = {
> > >
> > > /* SCIF1 (CN20: DEBUG SERIAL1) */
> > > PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.7", "pfc-r8a7790",
> > >
> > > "scif1_data", "scif1"),
> > >
> > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.8", "pfc-r8a7790",
> > > + "hscif0_data", "hscif0"),
> > > + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.9", "pfc-r8a7790",
> > > + "hscif1_data_b", "hscif1"),
> > >
> > > };
> > >
> > > static void __init lager_add_standard_devices(void)
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-17 2:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-31 15:57 [PATCH v3 5/5] ARM: shmobile: lager: map HSCIF0/1 to unused pins Ulrich Hecht
2013-06-11 7:52 ` Simon Horman
2013-06-12 14:08 ` Simon Horman
2013-06-14 16:51 ` Laurent Pinchart
2013-06-17 2:20 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).