From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ARM: shmobile: Armadillo800EVA: Convert SCIFA1 to pinctrl
Date: Wed, 17 Apr 2013 11:36:45 +0000 [thread overview]
Message-ID: <2801967.ePsIehJU62@avalon> (raw)
In-Reply-To: <1366194847-9879-2-git-send-email-hechtb+renesas@gmail.com>
Hi Bastian,
Thank you for the patch.
On Wednesday 17 April 2013 12:34:02 Bastian Hecht wrote:
> We use the new pinctrl framework now.
>
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> v2: same
>
> arch/arm/mach-shmobile/board-armadillo800eva.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c
> b/arch/arm/mach-shmobile/board-armadillo800eva.c index 81db74a..bf4c3d2
> 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -1048,6 +1048,9 @@ static const struct pinctrl_map eva_pinctrl_map[] = {
> "mmc0_data8_1", "mmc0"),
> PIN_MAP_MUX_GROUP_DEFAULT("sh_mmcif.0", "pfc-r8a7740",
> "mmc0_ctrl_1", "mmc0"),
> + /* SCIFA1 */
> + PIN_MAP_MUX_GROUP_DEFAULT("sh-sci.1", "pfc-r8a7740",
> + "scifa1_data", "scifa1"),
> /* SDHI0 */
> PIN_MAP_MUX_GROUP_DEFAULT("sh_mobile_sdhi.0", "pfc-r8a7740",
> "sdhi0_data4", "sdhi0"),
> @@ -1109,10 +1112,6 @@ static void __init eva_init(void)
> r8a7740_pinmux_init();
> r8a7740_meram_workaround();
>
> - /* SCIFA1 */
> - gpio_request(GPIO_FN_SCIFA1_RXD, NULL);
> - gpio_request(GPIO_FN_SCIFA1_TXD, NULL);
> -
> /* LCDC0 */
> gpio_request(GPIO_FN_LCDC0_SELECT, NULL);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-04-17 11:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 10:34 [PATCH v2 2/6] ARM: shmobile: Armadillo800EVA: Convert SCIFA1 to pinctrl Bastian Hecht
2013-04-17 11:36 ` Laurent Pinchart [this message]
2013-04-18 12:34 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2801967.ePsIehJU62@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox