From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: ARM64: renesas: r8a7795: Add graphics-related MSTP clocks
Date: Wed, 21 Oct 2015 21:41:49 +0000 [thread overview]
Message-ID: <28354162.n5AJuuLfzM@avalon> (raw)
Hi Geert,
On Wednesday 30 September 2015 14:19:34 Geert Uytterhoeven wrote:
> Hi Laurent,
>
> http://git.linuxtv.org/cgit.cgi/pinchartl/media.git/commit/?h=vsp1-kms-gen3-20150929&id12906b34fe88e4eceface078af9cd6b2fa0955e:
> > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index
> > ed192d480e355e11..bcba6b4b86f8e24f 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
> > @@ -413,6 +413,41 @@
> >
> > clock-indices = <R8A7795_CLK_SCIF2>;
> >
> > };
> >
> > + mstp6_clks: mstp6@e61501c0 {
> > + compatible > > "renesas,r8a7795-mstp-clocks", +
> > "renesas,cpg-mstp-clocks"; +
> > reg = <0 0xe6150148 0 4>, <0 0xe61501c0 0 4>; +
> > clocks = <
> > + &s2d1_clk &s2d1_clk
> > &s2d1_clk &s2d1_clk +
> > &s2d1_clk &s2d1_clk &s2d1_clk &s2d1_clk +
> > &s2d1_clk
> > + >;
> > + #clock-cells = <1>;
> > + clock-indices = <
> > + R8A7795_CLK_VSPD3
> > R8A7795_CLK_VSPD2 +
> > R8A7795_CLK_VSPD1 R8A7795_CLK_VSPD0 +
> > R8A7795_CLK_VSPBC R8A7795_CLK_VSPBD +
> > R8A7795_CLK_VSPI2 R8A7795_CLK_VSPI1 +
> > R8A7795_CLK_VSPI0
> > + >;
> > + };
> > +
> > + mstp7_clks: mstp7@e615014c {
> > + compatible > > "renesas,r8a7795-mstp-clocks", +
> > "renesas,cpg-mstp-clocks"; +
> > reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>; +
> > clocks = <&s2d1_clk>, <&s2d1_clk>, <&s2d1_clk>, +
> > <&s2d1_clk>, <&s2d1_clk>, <&s2d1_clk>, +
> > <&lvds_clk>, <&hdmi_clk>,
> > <&hdmi_clk>;
> This property counts 9 parent clocks...
>
> > + #clock-cells = <1>;
> > + clock-indices = <
> > + R8A7795_CLK_DU3
> > R8A7795_CLK_DU2 +
> > R8A7795_CLK_DU1 R8A7795_CLK_DU0 +
> > R8A7795_CLK_LVDS R8A7795_CLK_HDMI1 +
> > R8A7795_CLK_HDMI0
>
> ... while this property counts only 7 indices.
>
> I guess the first two parent clocks should be removed?
Oops :-) Yes, they should. I'll make sure to drop them when porting the patch
to the mssr DT bindings.
> > + >;
> > + };
--
Regards,
Laurent Pinchart
next reply other threads:[~2015-10-21 21:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-21 21:41 Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-09-30 12:19 ARM64: renesas: r8a7795: Add graphics-related MSTP clocks Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28354162.n5AJuuLfzM@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox