From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
Date: Tue, 11 Dec 2012 11:40:54 +0000 [thread overview]
Message-ID: <2861660.bMP77HcQxX@avalon> (raw)
In-Reply-To: <1355225657-18731-1-git-send-email-phil.edworthy@renesas.com>
On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> The INDTx register addresses were wrong.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
You can add
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
:-)
> ---
> v2:
> Included SoB line this time - doh!
>
> arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c
> b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644
> --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> @@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] > { };
>
> static struct pinmux_data_reg pinmux_data_regs[] = {
> - { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
> - { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
> - { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
> - { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
> - { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
> - { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
> - { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
> + { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
> + { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
> + { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
> + { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
> + { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
> + { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
> + { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
> GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-12-11 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-11 9:48 [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses Phil Edworthy
2012-12-11 10:56 ` Laurent Pinchart
2012-12-11 11:34 ` [PATCH v2] " Phil Edworthy
2012-12-11 11:40 ` Laurent Pinchart [this message]
2012-12-12 10:12 ` phil.edworthy
2012-12-13 0:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2861660.bMP77HcQxX@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).