* [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically
@ 2014-05-12 23:02 Laurent Pinchart
2014-05-13 8:14 ` Andy Shevchenko
2014-05-13 10:15 ` Laurent Pinchart
0 siblings, 2 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-12 23:02 UTC (permalink / raw)
To: linux-sh
This helps detecting duplicate includes.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/dma/sh/shdmac.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index dda7e75..7313537 100644
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -18,21 +18,21 @@
*
*/
+#include <linux/delay.h>
+#include <linux/dmaengine.h>
#include <linux/init.h>
+#include <linux/interrupt.h>
+#include <linux/kdebug.h>
#include <linux/module.h>
+#include <linux/notifier.h>
#include <linux/of.h>
#include <linux/of_device.h>
-#include <linux/slab.h>
-#include <linux/interrupt.h>
-#include <linux/dmaengine.h>
-#include <linux/delay.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
+#include <linux/rculist.h>
#include <linux/sh_dma.h>
-#include <linux/notifier.h>
-#include <linux/kdebug.h>
+#include <linux/slab.h>
#include <linux/spinlock.h>
-#include <linux/rculist.h>
#include "../dmaengine.h"
#include "shdma.h"
--
1.8.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically
2014-05-12 23:02 [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically Laurent Pinchart
@ 2014-05-13 8:14 ` Andy Shevchenko
2014-05-13 10:15 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2014-05-13 8:14 UTC (permalink / raw)
To: linux-sh
On Tue, 2014-05-13 at 01:02 +0200, Laurent Pinchart wrote:
> This helps detecting duplicate includes.
No need to do that, since we have nice helper
make includecheck
Similar comment to patch 3/6.
But if you have stronger explanation why it's needed besides that... you
are welcome )
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/dma/sh/shdmac.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
> index dda7e75..7313537 100644
> --- a/drivers/dma/sh/shdmac.c
> +++ b/drivers/dma/sh/shdmac.c
> @@ -18,21 +18,21 @@
> *
> */
>
> +#include <linux/delay.h>
> +#include <linux/dmaengine.h>
> #include <linux/init.h>
> +#include <linux/interrupt.h>
> +#include <linux/kdebug.h>
> #include <linux/module.h>
> +#include <linux/notifier.h>
> #include <linux/of.h>
> #include <linux/of_device.h>
> -#include <linux/slab.h>
> -#include <linux/interrupt.h>
> -#include <linux/dmaengine.h>
> -#include <linux/delay.h>
> #include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> +#include <linux/rculist.h>
> #include <linux/sh_dma.h>
> -#include <linux/notifier.h>
> -#include <linux/kdebug.h>
> +#include <linux/slab.h>
> #include <linux/spinlock.h>
> -#include <linux/rculist.h>
>
> #include "../dmaengine.h"
> #include "shdma.h"
--
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically
2014-05-12 23:02 [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically Laurent Pinchart
2014-05-13 8:14 ` Andy Shevchenko
@ 2014-05-13 10:15 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2014-05-13 10:15 UTC (permalink / raw)
To: linux-sh
Hi Andy,
On Tuesday 13 May 2014 11:14:20 Andy Shevchenko wrote:
> On Tue, 2014-05-13 at 01:02 +0200, Laurent Pinchart wrote:
> > This helps detecting duplicate includes.
>
> No need to do that, since we have nice helper
> make includecheck
We do, but it's much quicker and easier to spot the duplicate visually when
modifying the source code than having to run an external script.
> Similar comment to patch 3/6.
> But if you have stronger explanation why it's needed besides that... you
> are welcome )
>
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > drivers/dma/sh/shdmac.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
> > index dda7e75..7313537 100644
> > --- a/drivers/dma/sh/shdmac.c
> > +++ b/drivers/dma/sh/shdmac.c
> > @@ -18,21 +18,21 @@
> >
> > *
> > */
> >
> > +#include <linux/delay.h>
> > +#include <linux/dmaengine.h>
> >
> > #include <linux/init.h>
> >
> > +#include <linux/interrupt.h>
> > +#include <linux/kdebug.h>
> >
> > #include <linux/module.h>
> >
> > +#include <linux/notifier.h>
> >
> > #include <linux/of.h>
> > #include <linux/of_device.h>
> >
> > -#include <linux/slab.h>
> > -#include <linux/interrupt.h>
> > -#include <linux/dmaengine.h>
> > -#include <linux/delay.h>
> >
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> >
> > +#include <linux/rculist.h>
> >
> > #include <linux/sh_dma.h>
> >
> > -#include <linux/notifier.h>
> > -#include <linux/kdebug.h>
> > +#include <linux/slab.h>
> >
> > #include <linux/spinlock.h>
> >
> > -#include <linux/rculist.h>
> >
> > #include "../dmaengine.h"
> > #include "shdma.h"
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-13 10:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-12 23:02 [PATCH 1/6] DMA: shdmac: Keep #include sorted alphabetically Laurent Pinchart
2014-05-13 8:14 ` Andy Shevchenko
2014-05-13 10:15 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).