* Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
@ 2013-04-27 0:48 ` Laurent Pinchart
2013-04-27 14:41 ` Sergei Shtylyov
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-04-27 0:48 UTC (permalink / raw)
To: linux-sh
Hi Sergei,
Thank you for the patch.
On Saturday 27 April 2013 02:46:43 Sergei Shtylyov wrote:
> Add Ether RMII/LINK/MAGIC pin groups to R8A7778 PFC driver.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> Changes from version 2:
> - fixed whitespace errors/warnings reported by scripts/checkpatch.pl.
>
> Changes from the original posting:
> - resolved reject, refreshed the patch;
> - moved all pin groups to stay in the alphabetical order with the others;
> - made use of SH_PFC_*() macros where possible.
>
> drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> =================================> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> @@ -1323,6 +1323,22 @@ static struct sh_pfc_pin pinmux_pins[] > arg5##_MARK, arg6##_MARK, \
> arg7##_MARK, arg8##_MARK, }
>
> +/* - Ether
> ------------------------------------------------------------------ */
> +SH_PFC_PINS(ether_rmii, RCAR_GP_PIN(4, 10), RCAR_GP_PIN(4, 11),
> + RCAR_GP_PIN(4, 13), RCAR_GP_PIN(4, 9),
> + RCAR_GP_PIN(4, 15), RCAR_GP_PIN(4, 16),
> + RCAR_GP_PIN(4, 12), RCAR_GP_PIN(4, 14),
> + RCAR_GP_PIN(4, 18), RCAR_GP_PIN(4, 17));
> +static const unsigned int ether_rmii_mux[] = {
> + ETH_TXD0_MARK, ETH_TXD1_MARK, ETH_TX_EN_MARK, ETH_REF_CLK_MARK,
> + ETH_RXD0_MARK, ETH_RXD1_MARK, ETH_CRS_DV_MARK, ETH_RX_ER_MARK,
> + ETH_MDIO_MARK, ETH_MDC_MARK,
> +};
> +SH_PFC_PINS(ether_link, RCAR_GP_PIN(4, 19));
> +SH_PFC_MUX1(ether_link, ETH_LINK);
> +SH_PFC_PINS(ether_magic, RCAR_GP_PIN(4, 20));
> +SH_PFC_MUX1(ether_magic, ETH_MAGIC);
I really don't think the macros make the code more readable here, especially
with the explicit array/macros mix, but I won't nack the patch just for that.
> +
> /* - SCIF macro
> ------------------------------------------------------------- */ #define
> SCIF_PFC_PIN(name, args...) SH_PFC_PINS(name, args)
> #define SCIF_PFC_DAT(name, tx, rx) SH_PFC_MUX2(name, tx, rx)
> @@ -1542,6 +1558,9 @@ VIN_PFC_PINS(vin1_sync, RCAR_GP_PIN(3,
> VIN_PFC_SYNC(vin1_sync, VI1_HSYNC, VI1_VSYNC);
>
> static const struct sh_pfc_pin_group pinmux_groups[] = {
> + SH_PFC_PIN_GROUP(ether_rmii),
> + SH_PFC_PIN_GROUP(ether_link),
> + SH_PFC_PIN_GROUP(ether_magic),
> SH_PFC_PIN_GROUP(hscif0_data_a),
> SH_PFC_PIN_GROUP(hscif0_data_b),
> SH_PFC_PIN_GROUP(hscif0_ctrl_a),
> @@ -1618,6 +1637,12 @@ static const struct sh_pfc_pin_group pin
> SH_PFC_PIN_GROUP(vin1_sync),
> };
>
> +static const char * const ether_groups[] = {
> + "ether_rmii",
> + "ether_link",
> + "ether_magic",
> +};
> +
> static const char * const hscif0_groups[] = {
> "hscif0_data_a",
> "hscif0_data_b",
> @@ -1736,6 +1761,7 @@ static const char * const vin1_groups[]
> };
>
> static const struct sh_pfc_function pinmux_functions[] = {
> + SH_PFC_FUNCTION(ether),
> SH_PFC_FUNCTION(hscif0),
> SH_PFC_FUNCTION(hscif1),
> SH_PFC_FUNCTION(scif_clk),
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
2013-04-27 0:48 ` Laurent Pinchart
@ 2013-04-27 14:41 ` Sergei Shtylyov
2013-04-28 20:55 ` Laurent Pinchart
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2013-04-27 14:41 UTC (permalink / raw)
To: linux-sh
On 27-04-2013 4:48, Laurent Pinchart wrote:
> Thank you for the patch.
Not at all. :-)
> On Saturday 27 April 2013 02:46:43 Sergei Shtylyov wrote:
>> Add Ether RMII/LINK/MAGIC pin groups to R8A7778 PFC driver.
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>> Changes from version 2:
>> - fixed whitespace errors/warnings reported by scripts/checkpatch.pl.
>> Changes from the original posting:
>> - resolved reject, refreshed the patch;
>> - moved all pin groups to stay in the alphabetical order with the others;
>> - made use of SH_PFC_*() macros where possible.
>> drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
>> =================================>> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
>> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
>> @@ -1323,6 +1323,22 @@ static struct sh_pfc_pin pinmux_pins[] >> arg5##_MARK, arg6##_MARK, \
>> arg7##_MARK, arg8##_MARK, }
>>
>> +/* - Ether
>> ------------------------------------------------------------------ */
>> +SH_PFC_PINS(ether_rmii, RCAR_GP_PIN(4, 10), RCAR_GP_PIN(4, 11),
>> + RCAR_GP_PIN(4, 13), RCAR_GP_PIN(4, 9),
>> + RCAR_GP_PIN(4, 15), RCAR_GP_PIN(4, 16),
>> + RCAR_GP_PIN(4, 12), RCAR_GP_PIN(4, 14),
>> + RCAR_GP_PIN(4, 18), RCAR_GP_PIN(4, 17));
>> +static const unsigned int ether_rmii_mux[] = {
>> + ETH_TXD0_MARK, ETH_TXD1_MARK, ETH_TX_EN_MARK, ETH_REF_CLK_MARK,
>> + ETH_RXD0_MARK, ETH_RXD1_MARK, ETH_CRS_DV_MARK, ETH_RX_ER_MARK,
>> + ETH_MDIO_MARK, ETH_MDC_MARK,
>> +};
>> +SH_PFC_PINS(ether_link, RCAR_GP_PIN(4, 19));
>> +SH_PFC_MUX1(ether_link, ETH_LINK);
>> +SH_PFC_PINS(ether_magic, RCAR_GP_PIN(4, 20));
>> +SH_PFC_MUX1(ether_magic, ETH_MAGIC);
> I really don't think the macros make the code more readable here, especially
> with the explicit array/macros mix, but I won't nack the patch just for that.
But you won't ACK it either? :-)
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
2013-04-27 0:48 ` Laurent Pinchart
2013-04-27 14:41 ` Sergei Shtylyov
@ 2013-04-28 20:55 ` Laurent Pinchart
2013-05-03 7:40 ` Linus Walleij
2013-05-05 11:36 ` Sergei Shtylyov
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-04-28 20:55 UTC (permalink / raw)
To: linux-sh
Hi Sergei,
On Saturday 27 April 2013 18:41:27 Sergei Shtylyov wrote:
> On 27-04-2013 4:48, Laurent Pinchart wrote:
> > Thank you for the patch.
>
> Not at all. :-)
>
> > On Saturday 27 April 2013 02:46:43 Sergei Shtylyov wrote:
> >> Add Ether RMII/LINK/MAGIC pin groups to R8A7778 PFC driver.
> >>
> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>
> >> ---
> >> Changes from version 2:
> >> - fixed whitespace errors/warnings reported by scripts/checkpatch.pl.
> >>
> >> Changes from the original posting:
> >> - resolved reject, refreshed the patch;
> >> - moved all pin groups to stay in the alphabetical order with the others;
> >> - made use of SH_PFC_*() macros where possible.
> >>
> >> drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 26 ++++++++++++++++++++++++++
> >> 1 file changed, 26 insertions(+)
> >>
> >> Index: renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> >> =================================> >> --- renesas.orig/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> >> +++ renesas/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> >> @@ -1323,6 +1323,22 @@ static struct sh_pfc_pin pinmux_pins[] > >> arg5##_MARK, arg6##_MARK, \
> >> arg7##_MARK, arg8##_MARK, }
> >>
> >> +/* - Ether
> >> ------------------------------------------------------------------ */
> >> +SH_PFC_PINS(ether_rmii, RCAR_GP_PIN(4, 10), RCAR_GP_PIN(4, 11),
> >> + RCAR_GP_PIN(4, 13), RCAR_GP_PIN(4, 9),
> >> + RCAR_GP_PIN(4, 15), RCAR_GP_PIN(4, 16),
> >> + RCAR_GP_PIN(4, 12), RCAR_GP_PIN(4, 14),
> >> + RCAR_GP_PIN(4, 18), RCAR_GP_PIN(4, 17));
> >> +static const unsigned int ether_rmii_mux[] = {
> >> + ETH_TXD0_MARK, ETH_TXD1_MARK, ETH_TX_EN_MARK, ETH_REF_CLK_MARK,
> >> + ETH_RXD0_MARK, ETH_RXD1_MARK, ETH_CRS_DV_MARK, ETH_RX_ER_MARK,
> >> + ETH_MDIO_MARK, ETH_MDC_MARK,
> >> +};
> >> +SH_PFC_PINS(ether_link, RCAR_GP_PIN(4, 19));
> >> +SH_PFC_MUX1(ether_link, ETH_LINK);
> >> +SH_PFC_PINS(ether_magic, RCAR_GP_PIN(4, 20));
> >> +SH_PFC_MUX1(ether_magic, ETH_MAGIC);
> >
> > I really don't think the macros make the code more readable here,
> > especially with the explicit array/macros mix, but I won't nack the patch
> > just for that.
>
> But you won't ACK it either? :-)
I definitely wouldn't have written the code that way, but the patch looks OK
to me and can be applied. According to Documentation/SubmittingPatches that's
equivalent to
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
` (2 preceding siblings ...)
2013-04-28 20:55 ` Laurent Pinchart
@ 2013-05-03 7:40 ` Linus Walleij
2013-05-05 11:36 ` Sergei Shtylyov
4 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-05-03 7:40 UTC (permalink / raw)
To: linux-sh
On Sun, Apr 28, 2013 at 10:55 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Saturday 27 April 2013 18:41:27 Sergei Shtylyov wrote:
>> On 27-04-2013 4:48, Laurent Pinchart wrote:
>> > I really don't think the macros make the code more readable here,
>> > especially with the explicit array/macros mix, but I won't nack the patch
>> > just for that.
>>
>> But you won't ACK it either? :-)
>
> I definitely wouldn't have written the code that way, but the patch looks OK
> to me and can be applied. According to Documentation/SubmittingPatches that's
> equivalent to
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
If Laurent is OK with it, I'm OK with it.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups
2013-04-26 22:46 [PATCH v3 2/3] sh-pfc: r8a7778: add Ether pin groups Sergei Shtylyov
` (3 preceding siblings ...)
2013-05-03 7:40 ` Linus Walleij
@ 2013-05-05 11:36 ` Sergei Shtylyov
4 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2013-05-05 11:36 UTC (permalink / raw)
To: linux-sh
Hello.
On 03-05-2013 11:40, Linus Walleij wrote:
>>>> I really don't think the macros make the code more readable here,
>>>> especially with the explicit array/macros mix, but I won't nack the patch
>>>> just for that.
>>> But you won't ACK it either? :-)
>> I definitely wouldn't have written the code that way, but the patch looks OK
>> to me and can be applied. According to Documentation/SubmittingPatches that's
>> equivalent to
>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> If Laurent is OK with it, I'm OK with it.
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
How about patch #3 of this series?
> Yours,
> Linus Walleij
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread