Re: [PATCH v2 1/7] ARM: shmobile: ape6evm: synchronize dts with reference platform

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Ulrich,

On Wednesday 17 December 2014 09:38:54 Ulrich Hecht wrote:
> On Tue, Dec 16, 2014 at 11:38 PM, Laurent Pinchart wrote:
> > On Tuesday 16 December 2014 17:25:57 Ulrich Hecht wrote:
> [...]
> 
> >>       lbsc {
> >> 
> >> +             compatible = "simple-bus";
> >> 
> >>               #address-cells = <1>;
> >>               #size-cells = <1>;
> >> 
> >> +             ranges = <0 0 0 0x20000000>;
> >> 
> >>               ethernet@8000000 {
> >> 
> >> -                     compatible = "smsc,lan9118", "smsc,lan9115";
> >> +                     compatible = "smsc,lan9220", "smsc,lan9115";
> >> 
> >>                       reg = <0x08000000 0x1000>;
> >>                       interrupt-parent = <&irqc1>;
> >>                       interrupts = <8 IRQ_TYPE_LEVEL_HIGH>;
> > 
> > Which branch is this based on ? Simon's latest devel branch doesn't have a
> > /lbsc/ethernet node in arch/arm/boot/dts/r8a73a4-ape6evm-reference.dts.
> > The bootargs value is also different.
> 
> That's because the file isn't r8a73a4-ape6evm-reference.dts, it's
> r8a73a4-ape6evm.dts.
> 
> The idea here is to add all the bells and whistles to
> r8a73a4-ape6evm.dts instead of the reference file to avoid having to
> move it later.

The commit message gave me the impression that you were synchronizing the two 
.dts files to make them identical (except for the board compatible string). 
Could you either split the lan9220 compatible string change to a separate 
patch (as the change doesn't come from synchronization), or mention it 
explicitly in the commit message ?

-- 
Regards,

Laurent Pinchart