SUPERH platform development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 5/5] ARM: shmobile: koelsch: Rename SCIF[01] serial ports to ttySC[01]
Date: Tue, 02 Dec 2014 21:06:25 +0000	[thread overview]
Message-ID: <3090641.7NnSZVCixd@avalon> (raw)
In-Reply-To: <1417538146-23350-6-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

Hi Geert,

On Tuesday 02 December 2014 22:01:07 Geert Uytterhoeven wrote:
> On Tue, Dec 2, 2014 at 5:35 PM, Laurent Pinchart wrote:
> > There's no reason to name the only two available serial ports on the
> > board ttySC6 and ttySC7 (apart from confusing userspace, which we should
> > try to avoid).
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7791-koelsch.dts | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > b/arch/arm/boot/dts/r8a7791-koelsch.dts index 990af167c551..bf58c79a6554
> > 100644
> > --- a/arch/arm/boot/dts/r8a7791-koelsch.dts
> > +++ b/arch/arm/boot/dts/r8a7791-koelsch.dts
> > @@ -48,8 +48,8 @@
> >         compatible = "renesas,koelsch", "renesas,r8a7791";
> >         
> >         aliases {
> > -               serial6 = &scif0;
> > -               serial7 = &scif1;
> > +               serial0 = &scif0;
> > +               serial1 = &scif1;
> 
> Actually the labels on my Koelsch read "debug0" and "debug1".
> Do we care?

I thought serial port aliases were required to be named "serial" ?

-- 
Regards,

Laurent Pinchart


  parent reply	other threads:[~2014-12-02 21:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-02 16:35 [PATCH 5/5] ARM: shmobile: koelsch: Rename SCIF[01] serial ports to ttySC[01] Laurent Pinchart
2014-12-02 21:01 ` Geert Uytterhoeven
2014-12-02 21:06 ` Laurent Pinchart [this message]
2014-12-02 21:11 ` Geert Uytterhoeven
2014-12-02 21:34 ` Laurent Pinchart
2014-12-02 22:58 ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3090641.7NnSZVCixd@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox