* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
@ 2013-10-04 1:30 ` Kuninori Morimoto
2013-10-04 1:35 ` Kuninori Morimoto
` (9 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-04 1:30 UTC (permalink / raw)
To: linux-sh
Hi Simon
> Kuninori Morimoto (7):
> 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> 2) ARM: shmobile: bockw: use regulator for MMCIF
> 3) ARM: shmobile: bockw: add default PFC settings on DTS
> 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> 7) ARM: shmobile: bockw: add MMCIF support on DTS
>
> arch/arm/boot/dts/r8a7778-bockw-reference.dts | 25 ++++++++++++++++++++++++
> arch/arm/boot/dts/r8a7778.dtsi | 8 ++++++++
> arch/arm/configs/bockw_defconfig | 1 +
> arch/arm/mach-shmobile/board-bockw-reference.c | 12 ------------
> arch/arm/mach-shmobile/board-bockw.c | 13 ++++++++----
> arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> 6 files changed, 44 insertions(+), 16 deletions(-)
These are based on renesas-devel-20131003 tag
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
2013-10-04 1:30 ` Kuninori Morimoto
@ 2013-10-04 1:35 ` Kuninori Morimoto
2013-10-08 1:11 ` Simon Horman
` (8 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-04 1:35 UTC (permalink / raw)
To: linux-sh
Hi Simon again
> Kuninori Morimoto (7):
> 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> 2) ARM: shmobile: bockw: use regulator for MMCIF
> 3) ARM: shmobile: bockw: add default PFC settings on DTS
> 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> 7) ARM: shmobile: bockw: add MMCIF support on DTS
>
> arch/arm/boot/dts/r8a7778-bockw-reference.dts | 25 ++++++++++++++++++++++++
> arch/arm/boot/dts/r8a7778.dtsi | 8 ++++++++
> arch/arm/configs/bockw_defconfig | 1 +
> arch/arm/mach-shmobile/board-bockw-reference.c | 12 ------------
> arch/arm/mach-shmobile/board-bockw.c | 13 ++++++++----
> arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> 6 files changed, 44 insertions(+), 16 deletions(-)
And, these dpends on today's Laurent's
Subject: [PATCH] ARM: shmobile: r8a7778: Fix pin control device address in DT
Date: Thu, 3 Oct 2013 19:35:41 +0200
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
2013-10-04 1:30 ` Kuninori Morimoto
2013-10-04 1:35 ` Kuninori Morimoto
@ 2013-10-08 1:11 ` Simon Horman
2013-10-08 1:32 ` Kuninori Morimoto
` (7 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-08 1:11 UTC (permalink / raw)
To: linux-sh
[ Cc Laurent ]
On Thu, Oct 03, 2013 at 06:35:32PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon again
>
> > Kuninori Morimoto (7):
> > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> >
> > arch/arm/boot/dts/r8a7778-bockw-reference.dts | 25 ++++++++++++++++++++++++
> > arch/arm/boot/dts/r8a7778.dtsi | 8 ++++++++
> > arch/arm/configs/bockw_defconfig | 1 +
> > arch/arm/mach-shmobile/board-bockw-reference.c | 12 ------------
> > arch/arm/mach-shmobile/board-bockw.c | 13 ++++++++----
> > arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> > 6 files changed, 44 insertions(+), 16 deletions(-)
>
> And, these dpends on today's Laurent's
>
> Subject: [PATCH] ARM: shmobile: r8a7778: Fix pin control device address in DT
> Date: Thu, 3 Oct 2013 19:35:41 +0200
Thanks Morimoto-san.
Could you explain in a little more detail what the dependency is.
I am trying to work out if I should apply this series on top
of "ARM: shmobile: r8a7778: Fix pin control device address in DT"
or if they can be merged in parallel.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (2 preceding siblings ...)
2013-10-08 1:11 ` Simon Horman
@ 2013-10-08 1:32 ` Kuninori Morimoto
2013-10-08 2:07 ` Simon Horman
` (6 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-08 1:32 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > > Kuninori Morimoto (7):
> > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> > >
> > > arch/arm/boot/dts/r8a7778-bockw-reference.dts | 25 ++++++++++++++++++++++++
> > > arch/arm/boot/dts/r8a7778.dtsi | 8 ++++++++
> > > arch/arm/configs/bockw_defconfig | 1 +
> > > arch/arm/mach-shmobile/board-bockw-reference.c | 12 ------------
> > > arch/arm/mach-shmobile/board-bockw.c | 13 ++++++++----
> > > arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> > > 6 files changed, 44 insertions(+), 16 deletions(-)
> >
> > And, these dpends on today's Laurent's
> >
> > Subject: [PATCH] ARM: shmobile: r8a7778: Fix pin control device address in DT
> > Date: Thu, 3 Oct 2013 19:35:41 +0200
>
> Thanks Morimoto-san.
>
> Could you explain in a little more detail what the dependency is.
> I am trying to work out if I should apply this series on top
> of "ARM: shmobile: r8a7778: Fix pin control device address in DT"
> or if they can be merged in parallel.
"ARM: shmobile: r8a7778: Fix pin control device address in DT"
is bugfix patch for DT.
The kernel (especially, pfc settings = #3) doesn't work
without it.
Is this explain enough for you ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (3 preceding siblings ...)
2013-10-08 1:32 ` Kuninori Morimoto
@ 2013-10-08 2:07 ` Simon Horman
2013-10-08 2:57 ` Kuninori Morimoto
` (5 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-08 2:07 UTC (permalink / raw)
To: linux-sh
On Mon, Oct 07, 2013 at 06:32:38PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > > Kuninori Morimoto (7):
> > > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> > > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> > > >
> > > > arch/arm/boot/dts/r8a7778-bockw-reference.dts | 25 ++++++++++++++++++++++++
> > > > arch/arm/boot/dts/r8a7778.dtsi | 8 ++++++++
> > > > arch/arm/configs/bockw_defconfig | 1 +
> > > > arch/arm/mach-shmobile/board-bockw-reference.c | 12 ------------
> > > > arch/arm/mach-shmobile/board-bockw.c | 13 ++++++++----
> > > > arch/arm/mach-shmobile/clock-r8a7778.c | 1 +
> > > > 6 files changed, 44 insertions(+), 16 deletions(-)
> > >
> > > And, these dpends on today's Laurent's
> > >
> > > Subject: [PATCH] ARM: shmobile: r8a7778: Fix pin control device address in DT
> > > Date: Thu, 3 Oct 2013 19:35:41 +0200
> >
> > Thanks Morimoto-san.
> >
> > Could you explain in a little more detail what the dependency is.
> > I am trying to work out if I should apply this series on top
> > of "ARM: shmobile: r8a7778: Fix pin control device address in DT"
> > or if they can be merged in parallel.
>
> "ARM: shmobile: r8a7778: Fix pin control device address in DT"
> is bugfix patch for DT.
> The kernel (especially, pfc settings = #3) doesn't work
> without it.
> Is this explain enough for you ?
Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
DT" is not applied. When the pfc settings don't work does the kernel still
work as well as it did prior to patch #3 not being applied?
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (4 preceding siblings ...)
2013-10-08 2:07 ` Simon Horman
@ 2013-10-08 2:57 ` Kuninori Morimoto
2013-10-08 4:00 ` Simon Horman
` (4 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-08 2:57 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > > > > Kuninori Morimoto (7):
> > > > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > > 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> > > > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
(snip)
> > "ARM: shmobile: r8a7778: Fix pin control device address in DT"
> > is bugfix patch for DT.
> > The kernel (especially, pfc settings = #3) doesn't work
> > without it.
> > Is this explain enough for you ?
>
> Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
> DT" is not applied. When the pfc settings don't work does the kernel still
> work as well as it did prior to patch #3 not being applied?
#1, #2 will works well without fixup patch.
#3 need it, and
#4-#7 need #3 patch.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (5 preceding siblings ...)
2013-10-08 2:57 ` Kuninori Morimoto
@ 2013-10-08 4:00 ` Simon Horman
2013-10-08 20:59 ` Laurent Pinchart
` (3 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-08 4:00 UTC (permalink / raw)
To: linux-sh
On Mon, Oct 07, 2013 at 07:57:06PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > > > > Kuninori Morimoto (7):
> > > > > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > > > 4) ARM: shmobile: bockw: remove manual PFC settings on reference
> > > > > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> (snip)
> > > "ARM: shmobile: r8a7778: Fix pin control device address in DT"
> > > is bugfix patch for DT.
> > > The kernel (especially, pfc settings = #3) doesn't work
> > > without it.
> > > Is this explain enough for you ?
> >
> > Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
> > DT" is not applied. When the pfc settings don't work does the kernel still
> > work as well as it did prior to patch #3 not being applied?
>
> #1, #2 will works well without fixup patch.
I will see about queuing up #1 and #2 without further delay.
> #3 need it, and
> #4-#7 need #3 patch.
Thanks, I understand.
Laurent, could you let me know if you have a branch available
with "ARM: shmobile: r8a7778: Fix pin control device address in DT".
If not I'm happy to wait.
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (6 preceding siblings ...)
2013-10-08 4:00 ` Simon Horman
@ 2013-10-08 20:59 ` Laurent Pinchart
2013-10-09 0:11 ` Kuninori Morimoto
` (2 subsequent siblings)
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2013-10-08 20:59 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On Tuesday 08 October 2013 13:00:59 Simon Horman wrote:
> On Mon, Oct 07, 2013 at 07:57:06PM -0700, Kuninori Morimoto wrote:
> > Hi Simon
> >
> > > > > > > Kuninori Morimoto (7):
> > > > > > > 1) ARM: shmobile: bockw: enable CONFIG_REGULATOR
> > > > > > > 2) ARM: shmobile: bockw: use regulator for MMCIF
> > > > > > > 3) ARM: shmobile: bockw: add default PFC settings on DTS
> > > > > > > 4) ARM: shmobile: bockw: remove manual PFC settings on
> > > > > > > reference
> > > > > > > 5) ARM: shmobile: r8a7778: add MMCIF clock support for DT
> > > > > > > 6) ARM: shmobile: r8a7778: add MMCIF support on DTSI
> > > > > > > 7) ARM: shmobile: bockw: add MMCIF support on DTS
> >
> > (snip)
> >
> > > > "ARM: shmobile: r8a7778: Fix pin control device address in DT" is
> > > > bugfix patch for DT. The kernel (especially, pfc settings = #3)
> > > > doesn't work without it. Is this explain enough for you ?
> > >
> > > Assuming that "ARM: shmobile: r8a7778: Fix pin control device address in
> > > DT" is not applied. When the pfc settings don't work does the kernel
> > > still
> > > work as well as it did prior to patch #3 not being applied?
> >
> > #1, #2 will works well without fixup patch.
>
> I will see about queuing up #1 and #2 without further delay.
>
> > #3 need it, and
> > #4-#7 need #3 patch.
>
> Thanks, I understand.
>
> Laurent, could you let me know if you have a branch available with "ARM:
> shmobile: r8a7778: Fix pin control device address in DT". If not I'm happy
> to wait.
I don't have one. The bug got introduced in v3.12-rc1, without any serious
consequence as the DT node wasn't used. The fix might even break the bockw-
reference board if Morimoto-san's patch 4 isn't applied, as the PFC device
seems to be registered twice then (I haven't tested this).
Morimoto-san, could you please test my fix on bockw-reference without your
patch series ? If it doesn't break anything then we could push it to v3.12.
Otherwise we can include it with this series. Simon, would that be fine with
you ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (7 preceding siblings ...)
2013-10-08 20:59 ` Laurent Pinchart
@ 2013-10-09 0:11 ` Kuninori Morimoto
2013-10-09 20:20 ` Laurent Pinchart
2013-10-10 11:33 ` Simon Horman
10 siblings, 0 replies; 12+ messages in thread
From: Kuninori Morimoto @ 2013-10-09 0:11 UTC (permalink / raw)
To: linux-sh
Hi Simon, Laurent
> > Laurent, could you let me know if you have a branch available with "ARM:
> > shmobile: r8a7778: Fix pin control device address in DT". If not I'm happy
> > to wait.
>
> I don't have one. The bug got introduced in v3.12-rc1, without any serious
> consequence as the DT node wasn't used. The fix might even break the bockw-
> reference board if Morimoto-san's patch 4 isn't applied, as the PFC device
> seems to be registered twice then (I haven't tested this).
>
> Morimoto-san, could you please test my fix on bockw-reference without your
> patch series ? If it doesn't break anything then we could push it to v3.12.
> Otherwise we can include it with this series. Simon, would that be fine with
> you ?
I tested Laurent's fixup patch on
- latest linus/master + fixup patch
- renesas-devel-20131008 + fixup patch
both works well
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (8 preceding siblings ...)
2013-10-09 0:11 ` Kuninori Morimoto
@ 2013-10-09 20:20 ` Laurent Pinchart
2013-10-10 11:33 ` Simon Horman
10 siblings, 0 replies; 12+ messages in thread
From: Laurent Pinchart @ 2013-10-09 20:20 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san and Simon,
On Tuesday 08 October 2013 17:11:10 Kuninori Morimoto wrote:
> Hi Simon, Laurent
>
> > > Laurent, could you let me know if you have a branch available with "ARM:
> > > shmobile: r8a7778: Fix pin control device address in DT". If not I'm
> > > happy
> > > to wait.
> >
> > I don't have one. The bug got introduced in v3.12-rc1, without any serious
> > consequence as the DT node wasn't used. The fix might even break the
> > bockw-
> > reference board if Morimoto-san's patch 4 isn't applied, as the PFC device
> > seems to be registered twice then (I haven't tested this).
> >
> > Morimoto-san, could you please test my fix on bockw-reference without your
> > patch series ? If it doesn't break anything then we could push it to
> > v3.12.
> > Otherwise we can include it with this series. Simon, would that be fine
> > with you ?
>
> I tested Laurent's fixup patch on
>
> - latest linus/master + fixup patch
> - renesas-devel-20131008 + fixup patch
>
> both works well
Thank you for testing this.
Simon, would you like to pick up the patch for v3.12 ?
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT
2013-10-04 1:28 [PATCH 0/7] ARM: shmobile: bockw: MMCIF support on DT Kuninori Morimoto
` (9 preceding siblings ...)
2013-10-09 20:20 ` Laurent Pinchart
@ 2013-10-10 11:33 ` Simon Horman
10 siblings, 0 replies; 12+ messages in thread
From: Simon Horman @ 2013-10-10 11:33 UTC (permalink / raw)
To: linux-sh
On Wed, Oct 09, 2013 at 10:20:46PM +0200, Laurent Pinchart wrote:
> Hi Morimoto-san and Simon,
>
> On Tuesday 08 October 2013 17:11:10 Kuninori Morimoto wrote:
> > Hi Simon, Laurent
> >
> > > > Laurent, could you let me know if you have a branch available with "ARM:
> > > > shmobile: r8a7778: Fix pin control device address in DT". If not I'm
> > > > happy
> > > > to wait.
> > >
> > > I don't have one. The bug got introduced in v3.12-rc1, without any serious
> > > consequence as the DT node wasn't used. The fix might even break the
> > > bockw-
> > > reference board if Morimoto-san's patch 4 isn't applied, as the PFC device
> > > seems to be registered twice then (I haven't tested this).
> > >
> > > Morimoto-san, could you please test my fix on bockw-reference without your
> > > patch series ? If it doesn't break anything then we could push it to
> > > v3.12.
> > > Otherwise we can include it with this series. Simon, would that be fine
> > > with you ?
> >
> > I tested Laurent's fixup patch on
> >
> > - latest linus/master + fixup patch
> > - renesas-devel-20131008 + fixup patch
> >
> > both works well
>
> Thank you for testing this.
>
> Simon, would you like to pick up the patch for v3.12 ?
Hi Laurent, Hi Morimoto,
sorry for the confusion and delay.
Yes I can take that patch but as its not urgent I would prefer
to queue it up for v3.13 or at this stage more likely the distant v3.14.
^ permalink raw reply [flat|nested] 12+ messages in thread