* Re: [PATCH v2] sh-pfc: add R8A7794 PFC support [not found] <5262485.fuAdzVmykl@wasted.cogentembedded.com> @ 2015-02-15 16:06 ` Laurent Pinchart 2015-02-16 8:57 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Laurent Pinchart @ 2015-02-15 16:06 UTC (permalink / raw) To: Sergei Shtylyov Cc: linus.walleij, linux-sh, linux-gpio, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, devicetree Hi Sergei, Thank you for the patch. On Thursday 12 February 2015 00:01:18 Sergei Shtylyov wrote: > From: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > > Add PFC support for the R8A7794 SoC including pin groups for some on-chip > devices such as ETH, I2C, INTC, MSIOF, QSPI, [H]SCIF... > > Signed-off-by: Hisashi Nakamura <hisashi.nakamura.ak@renesas.com> > [Sergei: squashed together several patches, fixed the MLB_CLK typo, added > IRQ4.. IRQ9 pin groups, fixed IRQn comments, added ETH B pin group names, > removed stray new line and fixed typos in the comments in the > pinmux_config_regs[] initializer, added reasonable and removed unreasonable > copyrights, modified the bindings document, renamed, added changelog.] > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > --- > The patch is against the 'devel' branch of Linus W.'s 'linux-pinctrl.git' > repo. > > Changes in version 2: > - rebased the patch. > > Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt | 1 > drivers/pinctrl/sh-pfc/Kconfig | 5 > drivers/pinctrl/sh-pfc/Makefile | 1 > drivers/pinctrl/sh-pfc/core.c | 9 > drivers/pinctrl/sh-pfc/core.h | 1 > drivers/pinctrl/sh-pfc/pfc-r8a7794.c | 3989 ++ > 6 files changed, 4006 insertions(+) [snip] > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/core.c > =================================> --- linux-pinctrl.orig/drivers/pinctrl/sh-pfc/core.c > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/core.c > @@ -481,6 +481,12 @@ static const struct of_device_id sh_pfc_ > .data = &r8a7791_pinmux_info, > }, > #endif > +#ifdef CONFIG_PINCTRL_PFC_R8A7794 > + { > + .compatible = "renesas,pfc-r8a7794", > + .data = &r8a7794_pinmux_info, > + }, > +#endif > #ifdef CONFIG_PINCTRL_PFC_SH73A0 > { > .compatible = "renesas,pfc-sh73a0", > @@ -600,6 +606,9 @@ static const struct platform_device_id s > #ifdef CONFIG_PINCTRL_PFC_R8A7791 > { "pfc-r8a7791", (kernel_ulong_t)&r8a7791_pinmux_info }, > #endif > +#ifdef CONFIG_PINCTRL_PFC_R8A7794 > + { "pfc-r8a7794", (kernel_ulong_t)&r8a7794_pinmux_info }, R-Car E2 is DT-only, so there's no need for a platform_device_id entry. > +#endif > #ifdef CONFIG_PINCTRL_PFC_SH7203 > { "pfc-sh7203", (kernel_ulong_t)&sh7203_pinmux_info }, > #endif [snip] > Index: linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c > =================================> --- /dev/null > +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c > @@ -0,0 +1,3989 @@ > +/* > + * r8a7794 processor support - PFC hardware block. > + * > + * Copyright (C) 2014 Renesas Electronics Corporation > + * Copyright (C) 2015 Renesas Solutions Corp. > + * Copyright (C) 2015 Cogent Embedded, Inc., <source@cogentembedded.com> > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License version 2 > + * as published by the Free Software Foundation. > + */ > + > +#include <linux/kernel.h> > +#include <linux/platform_data/gpio-rcar.h> > + > +#include "core.h" > +#include "sh_pfc.h" > + > +#define CPU_ALL_PORT(fn, sfx) \ > + PORT_GP_32(0, fn, sfx), \ > + PORT_GP_32(1, fn, sfx), \ > + PORT_GP_32(2, fn, sfx), \ > + PORT_GP_32(3, fn, sfx), \ > + PORT_GP_32(4, fn, sfx), \ > + PORT_GP_32(5, fn, sfx), \ > + PORT_GP_32(6, fn, sfx) If I'm not mistaken port GP1 has 26 pins only, GP5 28 pins and GP6 26 pins. [snip] I haven't checked all pins in details, but the pin groups look sensible to me. -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] sh-pfc: add R8A7794 PFC support 2015-02-15 16:06 ` [PATCH v2] sh-pfc: add R8A7794 PFC support Laurent Pinchart @ 2015-02-16 8:57 ` Geert Uytterhoeven 2015-02-16 19:41 ` Laurent Pinchart 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2015-02-16 8:57 UTC (permalink / raw) To: Laurent Pinchart Cc: Sergei Shtylyov, Linus Walleij, Linux-sh list, linux-gpio@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org On Sun, Feb 15, 2015 at 5:06 PM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: >> --- /dev/null >> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c >> @@ -0,0 +1,3989 @@ >> +/* >> + * r8a7794 processor support - PFC hardware block. >> + * >> + * Copyright (C) 2014 Renesas Electronics Corporation >> + * Copyright (C) 2015 Renesas Solutions Corp. >> + * Copyright (C) 2015 Cogent Embedded, Inc., <source@cogentembedded.com> >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 >> + * as published by the Free Software Foundation. >> + */ >> + >> +#include <linux/kernel.h> >> +#include <linux/platform_data/gpio-rcar.h> >> + >> +#include "core.h" >> +#include "sh_pfc.h" >> + >> +#define CPU_ALL_PORT(fn, sfx) \ >> + PORT_GP_32(0, fn, sfx), \ >> + PORT_GP_32(1, fn, sfx), \ >> + PORT_GP_32(2, fn, sfx), \ >> + PORT_GP_32(3, fn, sfx), \ >> + PORT_GP_32(4, fn, sfx), \ >> + PORT_GP_32(5, fn, sfx), \ >> + PORT_GP_32(6, fn, sfx) > > If I'm not mistaken port GP1 has 26 pins only, GP5 28 pins and GP6 26 pins. That's correct. If that has to be reflected in the CPU_ALL_PORT() macro, a few existing pfc drivers should be modified, too: - on r8a7790, port GP1 and GP2 have 30 pins only, - on r8a7791, port GP1 has 26 pins only. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] sh-pfc: add R8A7794 PFC support 2015-02-16 8:57 ` Geert Uytterhoeven @ 2015-02-16 19:41 ` Laurent Pinchart 0 siblings, 0 replies; 3+ messages in thread From: Laurent Pinchart @ 2015-02-16 19:41 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Sergei Shtylyov, Linus Walleij, Linux-sh list, linux-gpio@vger.kernel.org, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, devicetree@vger.kernel.org Hi Geert, On Monday 16 February 2015 09:57:09 Geert Uytterhoeven wrote: > On Sun, Feb 15, 2015 at 5:06 PM, Laurent Pinchart wrote: > >> --- /dev/null > >> +++ linux-pinctrl/drivers/pinctrl/sh-pfc/pfc-r8a7794.c > >> @@ -0,0 +1,3989 @@ > >> +/* > >> + * r8a7794 processor support - PFC hardware block. > >> + * > >> + * Copyright (C) 2014 Renesas Electronics Corporation > >> + * Copyright (C) 2015 Renesas Solutions Corp. > >> + * Copyright (C) 2015 Cogent Embedded, Inc., > >> <source@cogentembedded.com> > >> + * > >> + * This program is free software; you can redistribute it and/or modify > >> + * it under the terms of the GNU General Public License version 2 > >> + * as published by the Free Software Foundation. > >> + */ > >> + > >> +#include <linux/kernel.h> > >> +#include <linux/platform_data/gpio-rcar.h> > >> + > >> +#include "core.h" > >> +#include "sh_pfc.h" > >> + > >> +#define CPU_ALL_PORT(fn, sfx) > >> \ + PORT_GP_32(0, fn, sfx), > >> \ + PORT_GP_32(1, fn, sfx), > >> \ + PORT_GP_32(2, fn, sfx), > >> \ + PORT_GP_32(3, fn, sfx), > >> \ + PORT_GP_32(4, fn, sfx), > >> \ + PORT_GP_32(5, fn, sfx), > >> \ + PORT_GP_32(6, fn, sfx) > > > > If I'm not mistaken port GP1 has 26 pins only, GP5 28 pins and GP6 26 > > pins. > > That's correct. > > If that has to be reflected in the CPU_ALL_PORT() macro, a few existing pfc > drivers should be modified, too: > - on r8a7790, port GP1 and GP2 have 30 pins only, > - on r8a7791, port GP1 has 26 pins only. Done :-) -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-16 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <5262485.fuAdzVmykl@wasted.cogentembedded.com>
2015-02-15 16:06 ` [PATCH v2] sh-pfc: add R8A7794 PFC support Laurent Pinchart
2015-02-16 8:57 ` Geert Uytterhoeven
2015-02-16 19:41 ` Laurent Pinchart
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).