From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 7/9] ARM: shmobile: lager: Enable DU device in DT
Date: Wed, 24 Sep 2014 13:09:24 +0000 [thread overview]
Message-ID: <3331193.6Bceue8bSn@avalon> (raw)
In-Reply-To: <1397511312-4845-8-git-send-email-ben.dooks@codethink.co.uk>
Hi Sergei,
Thank you for the review.
On Wednesday 24 September 2014 17:01:30 Sergei Shtylyov wrote:
> Hello.
>
> On 9/24/2014 4:27 PM, Laurent Pinchart wrote:
> > Specify the DU output topology, enable the DU device and configure the
> > related pins.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > arch/arm/boot/dts/r8a7790-lager.dts | 51 ++++++++++++++++++++++++++++---
> > 1 file changed, 48 insertions(+),
> > 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> > b/arch/arm/boot/dts/r8a7790-lager.dts index 84dcafa..a036d88 100644
> > --- a/arch/arm/boot/dts/r8a7790-lager.dts
> > +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> > @@ -144,6 +144,54 @@
> > states = <3300000 1
> > 1800000 0>;
> > };
> >
> > +
> > + adv7123 {
>
> Again, ePAPR dictates using generic device node names, not just chip names.
Sure, will fix.
> > + compatible = "adi,adv7123";
> > +
> > + #address-cells = <1>;
> > + #size-cells = <0>;
>
> Er, why? I don't see the "reg" props below...
The reg property is missing in the "port" nodes, and the #*-cells properties
should be moved to the "ports" node. I'll fix that.
> > +
> > + ports {
> > + port@0 {
> > + adv7123_in: endpoint {
> > + remote-endpoint = <&du_out_rgb>;
> > + };
> > + };
> > + port@1 {
> > + adv7123_out: endpoint {
> > + remote-endpoint = <&vga_in>;
> > + };
> > + };
> > + };
> > + };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-09-24 13:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-14 21:35 Updates Renesas OF-DMA code Ben Dooks
2014-04-14 21:35 ` [PATCH v2 1/9] ARM: shmobile: r8a7790: add dmac0,dmac1 clocks Ben Dooks
2014-05-13 9:23 ` Geert Uytterhoeven
2014-06-04 15:54 ` Ben Dooks
2014-04-14 21:35 ` [PATCH v2 2/9] ARM: shmobile: r8a7790: add dma defines for sys and audio dmacs Ben Dooks
2014-04-14 22:10 ` Arnd Bergmann
2014-04-14 22:51 ` Simon Horman
2014-04-15 9:46 ` Ben Dooks
2014-05-13 8:51 ` Geert Uytterhoeven
2014-05-13 10:46 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUsRSGuGgnAgjKtOWmx3C_PWUxAU=2XTvPE1M9o13S1uA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-05-27 8:08 ` Geert Uytterhoeven
2014-09-24 12:27 ` [PATCH v2 2/9] ARM: shmobile: r8a7790: Add DU node to device tree Laurent Pinchart
2014-04-14 21:35 ` [PATCH v2 3/9] ARM: shmobile: r8a7790: add dmac0 dmac1 nodes Ben Dooks
[not found] ` <1397511312-4845-4-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-05-13 12:00 ` Geert Uytterhoeven
[not found] ` <CAMuHMdUNAFJEFWYe5cpKaZqoZFhRA1s0YBntT5ZVJaieSj8ovQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-06-04 16:04 ` Ben Dooks
2014-05-15 13:11 ` Geert Uytterhoeven
2014-04-14 21:35 ` [PATCH v2 4/9] ARM: shmobile: r8a7790: Add DMA for MMCIF1 Ben Dooks
2014-04-14 21:35 ` [PATCH v2 5/9] ARM: shmobile: add Audio DMAC clocks Ben Dooks
2014-04-14 21:35 ` [PATCH v2 6/9] ARM: shmobile: r8a7790: add audio dmac node Ben Dooks
2014-05-13 8:53 ` Geert Uytterhoeven
2014-05-13 12:10 ` Geert Uytterhoeven
2014-05-15 13:12 ` Geert Uytterhoeven
[not found] ` <1397511312-4845-1-git-send-email-ben.dooks-4yDnlxn2s6sWdaTGBSpHTA@public.gmane.org>
2014-04-14 21:35 ` [PATCH v2 7/9] ARM: shmobile: lager: enable sysdma units 0 and 1 Ben Dooks
2014-09-24 12:27 ` [PATCH v2 7/9] ARM: shmobile: lager: Enable DU device in DT Laurent Pinchart
2014-09-24 13:01 ` Sergei Shtylyov
2014-09-24 13:09 ` Laurent Pinchart [this message]
2014-04-14 21:35 ` [PATCH v2 8/9] DMA: shdma: initial of common code Ben Dooks
2014-04-14 22:06 ` Arnd Bergmann
2014-04-15 9:54 ` Ben Dooks
2014-05-21 20:14 ` Geert Uytterhoeven
2014-06-04 15:54 ` Ben Dooks
2014-04-14 21:35 ` [PATCH v2 9/9] DMA: shdma: wire r8a7790 Ben Dooks
2014-04-15 12:20 ` Sergei Shtylyov
2014-04-18 1:32 ` Kuninori Morimoto
2014-04-23 13:08 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3331193.6Bceue8bSn@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).