Re: [PATCH v4 0/5] Renesas TPU PWM support

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Magnus, Morimoto-san,

On Tuesday 25 June 2013 08:40:03 Simon Horman wrote:
> On Fri, Jun 21, 2013 at 08:43:21AM +0200, Laurent Pinchart wrote:
> > On Friday 21 June 2013 15:15:28 Simon Horman wrote:
> > > On Thu, Jun 20, 2013 at 01:15:11PM +0200, Laurent Pinchart wrote:
> > > > On Monday 17 June 2013 12:31:39 Laurent Pinchart wrote:
> > > > > On Monday 17 June 2013 13:25:49 Simon Horman wrote:
> > > > > > Hi Laurent,
> > > > > > 
> > > > > > I am having a little trouble testing this.
> > > > > > I am wondering if you could guide me as to what .config options I
> > > > > > should have enabled and what values I should be looking for in
> > > > > > /sys ?
> > > > > 
> > > > > Sure. You need to enable CONFIG_LEDS_PWM and
> > > > > CONFIG_PWM_RENESAS_TPU).
> > > > > You should then be able to control the LEDs through
> > > > > /sys/class/leds/*.
> > > > 
> > > > Any luck ?
> > > 
> > > Hi Laurent,
> > > 
> > > I have confirmed that I can toggle the G H and J LEDs.

[snip]

> > > On the way I noticed the following:
> > > 
> > > sh-pfc pfc-sh73a0: pin PORT163 already requested by renesas-tpu-pwm.3;
> > > cannot claim for sh-sci.8 sh-pfc pfc-sh73a0: pin-163 (sh-sci.8) status
> > > -22
> > 
> > Pin 163 was used for both TPU LEDs and SCIFB RTS in the original board
> > code, hence the conflict. That's most probably a mistake. Do you have the
> > kota2 schematics ? If so, could you please confirm that pin 163 is used
> > for the LED only, not for SCIFB RTS ? I'll then send a patch to fix this.
> 
> I do not have the kota2 schematics.

Magnus or Morimoto-san, do you have access to the kota2 schematics ? If so, 
could you please check how pin 163 is used ?

> > > sh-pfc pfc-sh73a0: pin 1195 is not registered so it cannot be requested
> > > sh-pfc pfc-sh73a0: pin-1195 (sh_keysc.0) status -22
> > > sh-pfc pfc-sh73a0: could not request pin 1195 on device sh-pfc
> > > sh_keysc sh_keysc.0: Error applying setting, reverse things back
> > 
> > I'll work on that.
> > 
> > > My personal feeling is that if these are trivial to fix then it would be
> > > worth doing so. Otherwise a discussion needs to be had about support for
> > > the kota2.

-- 
Regards,

Laurent Pinchart