From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Mon, 15 Apr 2013 10:35:54 +0000 Subject: Re: [PATCH 0/4 v2] ARM: shmobile: r8a7778: pinctrl support Message-Id: <3487118.cA3WXyiLvL@avalon> List-Id: References: <87hajeka2q.wl%kuninori.morimoto.gx@renesas.com> In-Reply-To: <87hajeka2q.wl%kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org On Wednesday 10 April 2013 19:49:25 Kuninori Morimoto wrote: > Hi Simon, Laurent > > > > The patches look good, I just had a couple of comments on 1/3. I've > > > acked 2/3 and 3/3 already from v1, could you pick up the acks and add > > > them to v3 ? In general picking Acked-by, Reviewed-by and Tested-by > > > lines from the list when submitting a new version is a good idea, as it > > > helps reviewer skip patches they have already reviewed. > > > > It also helps the maintainer not to forget to add them :^) > > Thank you for pointing it. > And sorry for my immature behavior :( No worries. I've also forgotten to pick up acks several times in the past :-) -- Laurent Pinchart