From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Wed, 13 Nov 2013 11:29:13 +0000 Subject: Re: [PATCH] irqchip: renesas-intc-irqpin: Fix register bitfield shift calculation Message-Id: <3489458.0L98rnnZXN@avalon> List-Id: References: <1383999481-2742-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: <1383999481-2742-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org Hi Simon, On Wednesday 13 November 2013 15:22:08 Simon Horman wrote: > On Wed, Nov 13, 2013 at 01:14:37PM +0900, Magnus Damm wrote: > > On Wed, Nov 13, 2013 at 9:54 AM, Simon Horman wrote: > > > On Tue, Nov 12, 2013 at 02:24:34PM +0100, Laurent Pinchart wrote: > > >> On Tuesday 12 November 2013 14:08:40 Simon Horman wrote: > > >> > On Sat, Nov 09, 2013 at 01:18:01PM +0100, Laurent Pinchart wrote: > > >> > > The SENSE register bitfield position is incorrectly computed for > > >> > > SoCs that use 2-bit IRQ sense fields. Fix it. > > >> > > > > >> > > Signed-off-by: Laurent Pinchart > > >> > > > > >> > > > >> > Hi Laurent, > > >> > > > >> > your change seems correct to me but I am wondering if it should > > >> > be considered as a bug-fix? > > >> > > >> It's a bug fix, but given that the bug hasn't had any consequence so > > >> far, I'm not sure whether we really need to backport it to -stable. > > > > > > Thanks. I think the best thing would be to > > > try and get it into v3.13 as a fix but not worry about -stable. > > > > > > I will see about making it so. > > > > Thanks. Can you work with Laurent to briefly extend the commit message > > with information about which SoCs this has been tested on and such? I > > don't have any R-Car Gen1 boards myself so you guys will have to fix > > that. > > Yes of course. > > Laurent, I have access to both a Marzen (H1) and Bockw (M1) board. > Please let me know if you would like me to do any testing. I've tested the patch on a Marzen board, not a Lager board as erroneously stated in my e-mail. It would be worth it testing it on Bockw to make sure we were not in a situation where two wrongs made a right. -- Regards, Laurent Pinchart