From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Simon Horman <horms@verge.net.au>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-sh@vger.kernel.org, dri-devel@lists.freedesktop.org,
magnus.damm@gmail.com
Subject: Re: [PATCH 2/3] drm: Renesas R-Car Display Unit DRM driver
Date: Thu, 07 Feb 2013 16:08:41 +0000 [thread overview]
Message-ID: <3620099.Y0WWESBTg5@avalon> (raw)
In-Reply-To: <87k3qkzg5p.wl%kuninori.morimoto.gx@renesas.com>
On Thursday 07 February 2013 00:23:18 Kuninori Morimoto wrote:
> > I'm not sure of a good solution, however selecting OF where USE_OF wasn't
> > previously selected seems to cause problems on at least ARM because
> > devtree.c is then compiled without OF_FLATTREE selected.
Isn't that an ARM issue ? If OF && !OF_FLATTREE is a valid kernel
configuration devtree.c should compile.
> > That results in the following awesomeness as pointed out to me by
> > Morimoto-san.
I've run into that before as well. I'll remove the dependency on OF for now as
it's not strictly required.
> > arch/arm/kernel/devtree.c: In function 'arm_dt_memblock_reserve':
> > arch/arm/kernel/devtree.c:43:7: error: 'initial_boot_params' undeclared
> > (first use in this function) arch/arm/kernel/devtree.c:43:7: note: each
> > undeclared identifier is reported only once for each function it appears
> > in arch/arm/kernel/devtree.c: In function 'setup_machine_fdt':
> > arch/arm/kernel/devtree.c:193:2: error: 'initial_boot_params' undeclared
> > (first use in this function) arch/arm/kernel/devtree.c:194:2: error:
> > implicit declaration of function 'of_get_flat_dt_root'
> > arch/arm/kernel/devtree.c:196:3: error: implicit declaration of function
> > 'of_flat_dt_match' arch/arm/kernel/devtree.c:209:3: error: implicit
> > declaration of function 'of_get_flat_dt_prop'
> > arch/arm/kernel/devtree.c:209:8: warning: assignment makes pointer from
> > integer without a cast arch/arm/kernel/devtree.c:220:8: warning:
> > assignment makes pointer from integer without a cast
> > arch/arm/kernel/devtree.c:222:9: warning: assignment makes pointer from
> > integer without a cast arch/arm/kernel/devtree.c:228:2: error: implicit
> > declaration of function 'of_scan_flat_dt'
> > arch/arm/kernel/devtree.c:228:18: error: 'early_init_dt_scan_chosen'
> > undeclared (first use in this function) arch/arm/kernel/devtree.c:230:18:
> > error: 'early_init_dt_scan_root' undeclared (first use in this function)
> > arch/arm/kernel/devtree.c:232:18: error: 'early_init_dt_scan_memory'
> > undeclared (first use in this function) make[1]: ***
> > [arch/arm/kernel/devtree.o] Error 1
>
> OF_FLATTREE
> OF_EARLY_FLATTREE
>
> both are required ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-02-07 16:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 1:45 [PATCH 0/3] R-Car Display Unit DRM driver Laurent Pinchart
2013-01-31 1:45 ` [PATCH 1/3] r8a7779: Add Display Unit clock support Laurent Pinchart
2013-01-31 6:35 ` Simon Horman
2013-01-31 10:14 ` Laurent Pinchart
2013-02-01 0:06 ` Simon Horman
2013-02-07 2:20 ` Simon Horman
2013-03-12 15:08 ` Laurent Pinchart
2013-03-12 15:52 ` Simon Horman
2013-01-31 1:45 ` [PATCH 2/3] drm: Renesas R-Car Display Unit DRM driver Laurent Pinchart
2013-02-07 2:15 ` Simon Horman
2013-02-07 12:53 ` Laurent Pinchart
2013-02-07 7:32 ` Simon Horman
2013-02-07 8:23 ` Kuninori Morimoto
2013-02-07 16:08 ` Laurent Pinchart [this message]
2013-02-13 12:28 ` Simon Horman
2013-02-13 18:18 ` Laurent Pinchart
2013-02-14 0:40 ` Simon Horman
2013-01-31 1:45 ` [PATCH 3/3] ARM: shmobile: marzen: Add Display Unit support Laurent Pinchart
2013-02-07 4:27 ` Kuninori Morimoto
2013-02-07 12:51 ` Laurent Pinchart
2013-02-08 0:17 ` Kuninori Morimoto
2013-01-31 6:38 ` [PATCH 0/3] R-Car Display Unit DRM driver Simon Horman
2013-02-01 3:15 ` Laurent Pinchart
2013-02-01 3:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3620099.Y0WWESBTg5@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox