From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80BEDCCA481 for ; Fri, 24 Jun 2022 06:11:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbiFXGLm (ORCPT ); Fri, 24 Jun 2022 02:11:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229454AbiFXGLl (ORCPT ); Fri, 24 Jun 2022 02:11:41 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 53E8935DEE; Thu, 23 Jun 2022 23:11:40 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3F88B19F0; Thu, 23 Jun 2022 23:11:40 -0700 (PDT) Received: from [10.162.41.7] (unknown [10.162.41.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BE6293F66F; Thu, 23 Jun 2022 23:11:32 -0700 (PDT) Message-ID: <378e124f-914a-36b1-ff2f-9f4ea3b946a5@arm.com> Date: Fri, 24 Jun 2022 11:41:30 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" Cc: "hch@infradead.org" , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "sparclinux@vger.kernel.org" , "x86@kernel.org" , "openrisc@lists.librecores.org" , "linux-xtensa@linux-xtensa.org" , "linux-csky@vger.kernel.org" , "linux-hexagon@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-alpha@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-snps-arc@lists.infradead.org" , "linux-arm-kernel@lists.infradead.org" , "linux-um@lists.infradead.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20220624044339.1533882-1-anshuman.khandual@arm.com> <20220624044339.1533882-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sh@vger.kernel.org On 6/24/22 10:58, Christophe Leroy wrote: > > Le 24/06/2022 à 06:43, Anshuman Khandual a écrit : >> This just converts the generic vm_get_page_prot() implementation into a new >> macro i.e DECLARE_VM_GET_PAGE_PROT which later can be used across platforms >> when enabling them with ARCH_HAS_VM_GET_PAGE_PROT. This does not create any >> functional change. >> >> Cc: Andrew Morton >> Cc: linux-mm@kvack.org >> Cc: linux-kernel@vger.kernel.org >> Suggested-by: Christoph Hellwig >> Signed-off-by: Anshuman Khandual >> --- >> include/linux/mm.h | 8 ++++++++ >> mm/mmap.c | 6 +----- >> 2 files changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/include/linux/mm.h b/include/linux/mm.h >> index 47bfe038d46e..237828c2bae2 100644 >> --- a/include/linux/mm.h >> +++ b/include/linux/mm.h >> @@ -428,6 +428,14 @@ extern unsigned int kobjsize(const void *objp); >> extern pgprot_t protection_map[16]; >> #endif >> > I think the comment above protection_map[16] in mm/mmap.c should be > moved here. Sure, makes sense. Will move.